Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NonlinearSolve v3 Release #302

Merged
merged 7 commits into from
Dec 8, 2023
Merged

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Dec 5, 2023

Wait on #297, #303

Fixes #301, Fixes #300, Fixes #298, Fixes #293, Fixes #255

@ChrisRackauckas we need to update the compat entries for SimpleNonlinearSolve in OrdinaryDiffEq, ModelingToolkit, etc. for the doc build to go through

Main Changes

  1. Support only SimpleNonlinearSolve 1+
  2. Drop the old ad specification; only support a direct autodiff
  3. Update all documentation
  4. Pulled in some of the doc changes from Update NonlinearLeastSquaresSolvers docs and setup MINPACK/NLsolve as extension packages #276
  5. If the problem uses StaticArrays, we try to use a Simple* algorithm first for the non-caching solve

TODOs

@avik-pal avik-pal force-pushed the ap/breaking branch 3 times, most recently from 9a03a0a to 0dc27ae Compare December 7, 2023 01:51
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (b853842) 86.08% compared to head (50cef59) 85.99%.

Files Patch % Lines
ext/NonlinearSolveMINPACKExt.jl 77.50% 9 Missing ⚠️
ext/NonlinearSolveNLsolveExt.jl 86.66% 6 Missing ⚠️
src/extension_algs.jl 69.23% 4 Missing ⚠️
src/broyden.jl 88.88% 1 Missing ⚠️
src/default.jl 87.50% 1 Missing ⚠️
src/klement.jl 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
- Coverage   86.08%   85.99%   -0.09%     
==========================================
  Files          21       23       +2     
  Lines        1825     1935     +110     
==========================================
+ Hits         1571     1664      +93     
- Misses        254      271      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal avik-pal mentioned this pull request Dec 7, 2023
@avik-pal
Copy link
Member Author

avik-pal commented Dec 8, 2023

@ChrisRackauckas the docs build is working locally with SciML/OrdinaryDiffEq.jl#2076. The GPU failure which we are seeing on master needs a new tag for Adapt JuliaGPU/Adapt.jl#74. Finally #300, #301, #276 have been pulled in here

@ChrisRackauckas ChrisRackauckas merged commit 4e1638a into SciML:master Dec 8, 2023
10 of 12 checks passed
@avik-pal avik-pal deleted the ap/breaking branch December 8, 2023 02:23
@maleadt
Copy link

maleadt commented Dec 8, 2023

The GPU failure which we are seeing on master needs a new tag for Adapt JuliaGPU/Adapt.jl#74

JuliaRegistries/General#96765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code restrictions for merit function not documented Minor documentation problems Fix Documentation Issues
3 participants