Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Jacobian Based Algorithms if user supplies custom Jacobian #279

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Nov 6, 2023

No description provided.

Project.toml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
@avik-pal
Copy link
Member Author

avik-pal commented Nov 6, 2023

I want to test this with BoundaryValueDiffEq once before merging

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #279 (9782fd7) into master (c6c875f) will increase coverage by 44.67%.
The diff coverage is 80.00%.

@@             Coverage Diff             @@
##           master     #279       +/-   ##
===========================================
+ Coverage   48.45%   93.13%   +44.67%     
===========================================
  Files          19       19               
  Lines        1814     1821        +7     
===========================================
+ Hits          879     1696      +817     
+ Misses        935      125      -810     
Files Coverage Δ
src/broyden.jl 100.00% <100.00%> (+42.52%) ⬆️
src/klement.jl 90.99% <ø> (+25.22%) ⬆️
src/lbroyden.jl 93.23% <100.00%> (+93.23%) ⬆️
src/default.jl 76.92% <85.71%> (+45.88%) ⬆️
src/utils.jl 85.54% <0.00%> (+33.22%) ⬆️

... and 13 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@ChrisRackauckas ChrisRackauckas merged commit c2d0077 into SciML:master Nov 7, 2023
10 of 11 checks passed
@avik-pal avik-pal deleted the ap/better_default branch November 7, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants