Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LM for banded jacobian #272

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Nov 2, 2023

@avik-pal avik-pal force-pushed the ap/fix_lm branch 3 times, most recently from a97d2cc to 85c5d64 Compare November 2, 2023 01:49
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #272 (89b2781) into master (b07360f) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
+ Coverage   93.49%   93.56%   +0.07%     
==========================================
  Files          19       19              
  Lines        1782     1804      +22     
==========================================
+ Hits         1666     1688      +22     
  Misses        116      116              
Files Coverage Δ
src/NonlinearSolve.jl 98.55% <100.00%> (+0.67%) ⬆️
src/levenberg.jl 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@avik-pal avik-pal changed the title [WIP] Fix LM for banded jacobian Fix LM for banded jacobian Nov 2, 2023
@avik-pal avik-pal force-pushed the ap/fix_lm branch 2 times, most recently from 3ec3b19 to 0d89100 Compare November 2, 2023 14:11
@avik-pal
Copy link
Member Author

avik-pal commented Nov 2, 2023

I think we can go ahead with this. The 23 test problems for some seem a bit flaky. This PR doesn't even tough Broyden and it broke...

@ChrisRackauckas ChrisRackauckas merged commit 37a62f2 into SciML:master Nov 2, 2023
10 of 11 checks passed
@avik-pal avik-pal deleted the ap/fix_lm branch November 2, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants