Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't change the default termination condition #264

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

avik-pal
Copy link
Member

No description provided.

@avik-pal
Copy link
Member Author

NLSolveDefault is from SimpleNonlinearSolve which works fine work simple usecases but for general problems it is almost always a terrible choice

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #264 (c428bd9) into master (8fe131a) will increase coverage by 0.34%.
The diff coverage is 69.23%.

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
+ Coverage   92.74%   93.08%   +0.34%     
==========================================
  Files          19       19              
  Lines        1806     1794      -12     
==========================================
- Hits         1675     1670       -5     
+ Misses        131      124       -7     
Files Coverage Δ
src/broyden.jl 100.00% <100.00%> (+3.40%) ⬆️
src/dfsane.jl 100.00% <100.00%> (ø)
src/klement.jl 86.60% <100.00%> (ø)
src/levenberg.jl 98.86% <100.00%> (ø)
src/pseudotransient.jl 100.00% <100.00%> (ø)
src/raphson.jl 100.00% <100.00%> (ø)
src/trustRegion.jl 99.37% <100.00%> (ø)
src/gaussnewton.jl 78.31% <66.66%> (ø)
src/utils.jl 82.63% <36.36%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas ChrisRackauckas merged commit 3565824 into SciML:master Oct 27, 2023
8 of 11 checks passed
@avik-pal avik-pal deleted the ap/patch branch October 27, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants