Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scary Load Times in 1.9 #261

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

avik-pal
Copy link
Member

  • Use @recompile_invalidations

@avik-pal avik-pal force-pushed the ap/precompile branch 5 times, most recently from 93f87cf to 9d7d186 Compare October 25, 2023 22:16
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #261 (8e25204) into master (786e8d3) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
+ Coverage   92.47%   92.52%   +0.05%     
==========================================
  Files          18       18              
  Lines        1687     1700      +13     
==========================================
+ Hits         1560     1573      +13     
  Misses        127      127              
Files Coverage Δ
src/NonlinearSolve.jl 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@avik-pal avik-pal changed the title [WIP] Scary Load Times in 1.9 Scary Load Times in 1.9 Oct 25, 2023
@avik-pal
Copy link
Member Author

The problem seems to have been fixed (atleast on CI)

@ErikQQY
Copy link
Member

ErikQQY commented Oct 26, 2023

Tested on Julia 1.9.3:

julia> @time using NonlinearSolve
[ Info: Precompiling NonlinearSolve [8913a72c-1f9b-4ce2-8d82-65094dcecaec]
 89.902674 seconds (6.52 M allocations: 423.038 MiB, 3.10% gc time, 0.86% compilation time)

@ChrisRackauckas ChrisRackauckas merged commit f1bb4a7 into SciML:master Oct 26, 2023
10 of 11 checks passed
@avik-pal avik-pal deleted the ap/precompile branch October 26, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants