[WIP]:Pseudo-Transient method #215
Conversation
|
That URL doesn't work. Which paper? |
src/NonlinearSolve.jl
Outdated
| @@ -37,6 +37,7 @@ include("utils.jl") | |||
| include("raphson.jl") | |||
| include("trustRegion.jl") | |||
| include("levenberg.jl") | |||
| include("pseudoTransient.jl") | |||
There was a problem hiding this comment.
please follow standard naming conventions. psudotransient.jl for the page should be fine.
src/jacobian.jl
Outdated
| J_new = J - (1/alpha) * I | ||
| linprob = LinearProblem(J_new, _vec(zero(u)); u0 = _vec(zero(u))) |
There was a problem hiding this comment.
What difference does this make?
There was a problem hiding this comment.
If J is a VecJac operator, then the addition constructs an AddedOperator. needed for Krylov Subspace compatibility.
There was a problem hiding this comment.
Without this the types wont match in dolinsolve
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
==========================================
- Coverage 94.94% 92.95% -1.99%
==========================================
Files 8 8
Lines 732 781 +49
==========================================
+ Hits 695 726 +31
- Misses 37 55 +18
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…to avoid growing ill-conditioning
…nt with the rest of the package)
…oids a bug due to mutation of Jacobian in dolinsolve.
TrustRegion bugs
Co-authored-by: Avik Pal <[email protected]>
remove precompile on v1.9
…arSolve.jl into yd/pseudo-transient
|
Open a new PR for this. Also, set your git config to rebase and not merge on pull. Otherwise, these disastrous merges happen. |
This PR implements pseudo transient method using the adaptive step size given https://www.semanticscholar.org/paper/Explicit-pseudo-transient-continuation-Kelley-Liao/57061a163326620d425435d98e51fbe0aa14f1cc?p2df