Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use NLStats #190

Merged
merged 2 commits into from
Jun 7, 2023
Merged

use NLStats #190

merged 2 commits into from
Jun 7, 2023

Conversation

oscardssmith
Copy link
Contributor

Remade without conflicts. This definitely needs a review to make sure I have updated everything properly.

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #190 (11185fe) into master (753173e) will increase coverage by 38.42%.
The diff coverage is 93.33%.

@@             Coverage Diff             @@
##           master     #190       +/-   ##
===========================================
+ Coverage   55.34%   93.77%   +38.42%     
===========================================
  Files           7        7               
  Lines         645      675       +30     
===========================================
+ Hits          357      633      +276     
+ Misses        288       42      -246     
Impacted Files Coverage Δ
src/NonlinearSolve.jl 100.00% <ø> (ø)
src/ad.jl 100.00% <ø> (+100.00%) ⬆️
src/jacobian.jl 87.17% <33.33%> (+46.91%) ⬆️
src/utils.jl 74.28% <80.00%> (+55.71%) ⬆️
src/levenberg.jl 96.07% <100.00%> (+6.49%) ⬆️
src/raphson.jl 97.56% <100.00%> (+21.17%) ⬆️
src/trustRegion.jl 97.62% <100.00%> (+51.53%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas
Copy link
Member

Please make a clean diff. Don't mix format updates with code changes.

@oscardssmith
Copy link
Contributor Author

The formatting changes are all in a separate commit. I put them in the same PR to lower work, but the first commit contains all the changes.

@ChrisRackauckas ChrisRackauckas merged commit 79995ab into SciML:master Jun 7, 2023
@oscardssmith oscardssmith deleted the use-NLStats branch June 8, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants