iip vs oop iteration test

[yash2798]

No description provided.

[codecov]

Codecov Report

Merging #179 (99fc63f) into master (c1267c8) will increase coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage   92.92%   93.08%   +0.15%     
==========================================
  Files           7        7              
  Lines         636      636              
==========================================
+ Hits          591      592       +1     
+ Misses         45       44       -1     

Impacted Files	Coverage Δ
src/trustRegion.jl	97.54% <ø> (+0.40%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ChrisRackauckas]

I don't understand what you're doing here. Just run the code with maxiters = 1,2,3,4,5 and then check that the results are the same between the two modes?

[yash2798]

I don't understand what you're doing here. Just run the code with maxiters = 1,2,3,4,5 and then check that the results are the same between the two modes?

Yeah, but I was thinking maybe this would be beneficial when we benchmark different schemes later, like to see how different methods converge differently. So, instead of doing maxiters=1,2,3... again and again, we can just simply store the values? Does this make sense?

[ChrisRackauckas]

No because this will increase the memory requirement of the method. We shouldn't add cruft to the method for the benchmarking/testing purpose here when we don't need to.

[yash2798]

No because this will increase the memory requirement of the method. We shouldn't add cruft to the method for the benchmarking/testing purpose here when we don't need to.

okay sure got it, i'll just add the test then

[yash2798]

these tests pass. maybe this can be merged and i can add tests for more complex functions in the next PRs?