Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trust Region - Fan's method #178

Merged
merged 4 commits into from
Apr 11, 2023
Merged

Conversation

yash2798
Copy link
Member

@yash2798 yash2798 commented Apr 8, 2023

No description provided.

@yash2798 yash2798 changed the title Trust Region - Fan's method WIP - Trust Region - Fan's method Apr 8, 2023
@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Merging #178 (05a3e99) into master (c698d16) will increase coverage by 1.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
+ Coverage   91.88%   92.92%   +1.03%     
==========================================
  Files           7        7              
  Lines         604      636      +32     
==========================================
+ Hits          555      591      +36     
+ Misses         49       45       -4     
Impacted Files Coverage Δ
src/trustRegion.jl 97.13% <100.00%> (+2.31%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yash2798
Copy link
Member Author

Hi @ChrisRackauckas , line 307 and 309, is it alright if I calculate jacobian through direct ForwardDiff.jacobian calls? If Hei's scheme is used they'll be calculated only once in the cache init function

@yash2798
Copy link
Member Author

nvm i think jvp will work here too.

@yash2798
Copy link
Member Author

@ChrisRackauckas if this seems alright, this can be merged.

@yash2798 yash2798 changed the title WIP - Trust Region - Fan's method Trust Region - Fan's method Apr 11, 2023
@ChrisRackauckas ChrisRackauckas merged commit c1267c8 into SciML:master Apr 11, 2023
@ChrisRackauckas
Copy link
Member

Next step, can we get a test that like 4 iterations of in-place and out-of-place match results?

@yash2798
Copy link
Member Author

Next step, can we get a test that like 4 iterations of in-place and out-of-place match results?

Sure I will make a pr for this soon.

@yash2798 yash2798 deleted the ys/tr_fan branch April 19, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants