Enable iterator interface to be used with TrustRegion #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't spot some whitespace changes have crept in when I committed. I'll revert those. |
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
==========================================
+ Coverage 84.58% 85.08% +0.49%
==========================================
Files 7 7
Lines 571 590 +19
==========================================
+ Hits 483 502 +19
Misses 88 88
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ChrisRackauckas
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #173, this adds the
reinit!interface for theTrustRegionalgorithm, along with associated tests.I've been through the trust region code quite carefully and pulled out all the variables that need reinitialising.
I also fixed a typo in the default arguments of
reinit!forNewtonRaphsonCache.