Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the types in Levenberg #134

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Conversation

Deltadahl
Copy link
Contributor

Changing the types in levenberg.jl to match the input u0 given by the user as #132 (comment) suggests for trustRegion.jl

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #134 (bcb3338) into master (e839519) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   90.89%   91.00%   +0.10%     
==========================================
  Files           7        7              
  Lines         494      500       +6     
==========================================
+ Hits          449      455       +6     
  Misses         45       45              
Impacted Files Coverage Δ
src/levenberg.jl 95.86% <100.00%> (+0.17%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Deltadahl
Copy link
Contributor Author

Deltadahl commented Jan 24, 2023

I don't find any place where making the input rational would change anything.
In all cases, I just take the input given by the user or the default values

damping_initial::Real = 1.0,
damping_increase_factor::Real = 2.0,
damping_decrease_factor::Real = 3.0,
finite_diff_step_geodesic::Real = 0.1,
α_geodesic::Real = 0.75,
b_uphill::Real = 1.0,
min_damping_D::AbstractFloat = 1e-8)

and then convert it to the element type of u by x = convert(eltype(u), alg.x) before putting x into cache.

@ChrisRackauckas ChrisRackauckas merged commit e1c35f5 into SciML:master Jan 24, 2023
avik-pal pushed a commit that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants