Bug fix for TrustRegion when iip=true. #125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the bug that currently exists in the
TrustRegion
solver wheniip=true
#124.The bug went trough testing because the tests did not take the absolute value, allowing all negative values to pass, i.e.
@test all(sol.u .* sol.u .- 2 .< 1e-9)
and not@test all(abs.(sol.u .* sol.u .- 2) .< 1e-9)
as it should be.The bug is due to that
cache.u
andcache.fu
points to the same vector ascache.u_tmp
andcache.fu_new
respectively, and then both of them get changed at unwanted places.