Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jacobian erroneously calls finite_difference_derivative #12

Closed
danielwe opened this issue Nov 22, 2020 · 0 comments · Fixed by #13
Closed

jacobian erroneously calls finite_difference_derivative #12

danielwe opened this issue Nov 22, 2020 · 0 comments · Fixed by #13

Comments

@danielwe
Copy link
Contributor

This call should go to FiniteDiff.finite_difference_jacobian:

https://github.com/JuliaComputing/NonlinearSolve.jl/blob/cd00b8e4e3302be2cc724de126f5ca184d0e252e/src/jacobian.jl#L35

The reason the tests still pass is that the solution to the test problem is proportional to the initial guess, and the test function works for scalar u. If you change the initial guess so that it's not proportional to [1.0, 1.0] the algorithm will fail to converge, and if you use a function that fails for scalar u (e.g., by indexing into it) an exception will be thrown when trying to compute the jacobian.

avik-pal pushed a commit that referenced this issue Nov 1, 2024
Support complex in newton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant