refactor: remove Zygote extension

SciML · Oct 3, 2024 · d6b5536 · d6b5536
1 parent fa575c6
commit d6b5536
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 21 deletions.
diff --git a/Project.toml b/Project.toml
@@ -45,7 +45,6 @@ NLSolvers = "337daf1e-9722-11e9-073e-8b9effe078ba"
 NLsolve = "2774e3e8-f4cf-5e23-947b-6d7e65073b56"
 SIAMFANLEquations = "084e46ad-d928-497d-ad5e-07fa361a48c4"
 SpeedMapping = "f1835b91-879b-4a3f-a438-e4baacf14412"
-Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"
 
 [extensions]
 NonlinearSolveBandedMatricesExt = "BandedMatrices"
@@ -57,7 +56,6 @@ NonlinearSolveNLSolversExt = "NLSolvers"
 NonlinearSolveNLsolveExt = "NLsolve"
 NonlinearSolveSIAMFANLEquationsExt = "SIAMFANLEquations"
 NonlinearSolveSpeedMappingExt = "SpeedMapping"
-NonlinearSolveZygoteExt = "Zygote"
 
 [compat]
 ADTypes = "1.9"

diff --git a/ext/NonlinearSolveZygoteExt.jl b/ext/NonlinearSolveZygoteExt.jl
diff --git a/src/NonlinearSolve.jl b/src/NonlinearSolve.jl
@@ -61,9 +61,6 @@ using SparseMatrixColorings: ConstantColoringAlgorithm, GreedyColoringAlgorithm,
 
 const DI = DifferentiationInterface
 
-# Type-Inference Friendly Check for Extension Loading
-is_extension_loaded(::Val) = false
-
 const True = Val(true)
 const False = Val(false)
 

diff --git a/src/internal/helpers.jl b/src/internal/helpers.jl
@@ -80,7 +80,7 @@ function get_concrete_reverse_ad(
     else
         use_sparse_ad = false
     end
-    ad = if isinplace(prob) || !is_extension_loaded(Val(:Zygote)) # Use Finite Differencing
+    ad = if isinplace(prob) || !DI.check_available(AutoZygote()) # Use Finite Differencing
         use_sparse_ad ? AutoSparse(AutoFiniteDiff()) : AutoFiniteDiff()
     else
         use_sparse_ad ? AutoSparse(AutoZygote()) : AutoZygote()

diff --git a/test/misc/bruss_tests.jl b/test/misc/bruss_tests.jl
@@ -52,12 +52,6 @@
     sol = solve(prob_brusselator_2d_sparse, NewtonRaphson(); abstol = 1e-8)
     @test norm(sol.resid, Inf) < 1e-8
 
-    prob_brusselator_2d_sparse = NonlinearProblem(
-        NonlinearFunction(brusselator_2d_loop; sparsity = SymbolicsSparsityDetector()),
-        u0, p)
-    sol = solve(prob_brusselator_2d_sparse, NewtonRaphson(); abstol = 1e-8)
-    @test norm(sol.resid, Inf) < 1e-8
-
     # Deprecated
     sol = solve(prob_brusselator_2d,
         NewtonRaphson(autodiff = AutoSparse(AutoFiniteDiff())); abstol = 1e-8)

diff --git a/test/misc/qa_tests.jl b/test/misc/qa_tests.jl
@@ -17,8 +17,7 @@ end
 @testitem "Explicit Imports" tags=[:misc] begin
     using NonlinearSolve, ADTypes, SimpleNonlinearSolve, SciMLBase
     import BandedMatrices, FastLevenbergMarquardt, FixedPointAcceleration,
-           LeastSquaresOptim, MINPACK, NLsolve, NLSolvers, SIAMFANLEquations, SpeedMapping,
-           Zygote
+           LeastSquaresOptim, MINPACK, NLsolve, NLSolvers, SIAMFANLEquations, SpeedMapping
 
     using ExplicitImports