Skip to content

Commit

Permalink
Revert "Default to polyester forward diff"
Browse files Browse the repository at this point in the history
This reverts commit bb62c6c.
  • Loading branch information
avik-pal committed Jan 30, 2024
1 parent b4ce45d commit c9f7d3c
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 22 deletions.
8 changes: 2 additions & 6 deletions Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ FixedPointAcceleration = "817d07cb-a79a-5c30-9a31-890123675176"
LeastSquaresOptim = "0fc2ff8b-aaa3-5acd-a817-1944a5e08891"
MINPACK = "4854310b-de5a-5eb6-a2a5-c1dee2bd17f9"
NLsolve = "2774e3e8-f4cf-5e23-947b-6d7e65073b56"
PolyesterForwardDiff = "98d1487c-24ca-40b6-b7ab-df2af84e126b"
SIAMFANLEquations = "084e46ad-d928-497d-ad5e-07fa361a48c4"
SpeedMapping = "f1835b91-879b-4a3f-a438-e4baacf14412"
Symbolics = "0c5d862f-8b57-4792-8d23-62f2024744c7"
Expand All @@ -49,7 +48,6 @@ NonlinearSolveFixedPointAccelerationExt = "FixedPointAcceleration"
NonlinearSolveLeastSquaresOptimExt = "LeastSquaresOptim"
NonlinearSolveMINPACKExt = "MINPACK"
NonlinearSolveNLsolveExt = "NLsolve"
NonlinearSolvePolyesterForwardDiffExt = "PolyesterForwardDiff"
NonlinearSolveSIAMFANLEquationsExt = "SIAMFANLEquations"
NonlinearSolveSpeedMappingExt = "SpeedMapping"
NonlinearSolveSymbolicsExt = "Symbolics"
Expand Down Expand Up @@ -85,7 +83,6 @@ Pkg = "1.10"
PrecompileTools = "1.2"
Preferences = "1.4"
Printf = "1.10"
PolyesterForwardDiff = "0.1.1"
Random = "1.91"
RecursiveArrayTools = "3.4"
Reexport = "1.2"
Expand All @@ -94,7 +91,7 @@ SafeTestsets = "0.1"
SciMLBase = "2.19.0"
SimpleNonlinearSolve = "1.2"
SparseArrays = "1.10"
SparseDiffTools = "2.16"
SparseDiffTools = "2.14"
SpeedMapping = "0.3"
StableRNGs = "1"
StaticArrays = "1.7"
Expand Down Expand Up @@ -124,7 +121,6 @@ NaNMath = "77ba4419-2d1f-58cd-9bb1-8ffee604a2e3"
NonlinearProblemLibrary = "b7050fa9-e91f-4b37-bcee-a89a063da141"
OrdinaryDiffEq = "1dea7af3-3e70-54e6-95c3-0bf5283fa5ed"
Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
PolyesterForwardDiff = "98d1487c-24ca-40b6-b7ab-df2af84e126b"
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
SIAMFANLEquations = "084e46ad-d928-497d-ad5e-07fa361a48c4"
SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
Expand All @@ -138,4 +134,4 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"

[targets]
test = ["Aqua", "Enzyme", "BenchmarkTools", "SafeTestsets", "Pkg", "Test", "ForwardDiff", "StaticArrays", "Symbolics", "LinearSolve", "Random", "LinearAlgebra", "Zygote", "SparseDiffTools", "NonlinearProblemLibrary", "LeastSquaresOptim", "FastLevenbergMarquardt", "NaNMath", "BandedMatrices", "DiffEqBase", "StableRNGs", "MINPACK", "NLsolve", "OrdinaryDiffEq", "SpeedMapping", "FixedPointAcceleration", "SIAMFANLEquations", "Sundials", "PolyesterForwardDiff"]
test = ["Aqua", "Enzyme", "BenchmarkTools", "SafeTestsets", "Pkg", "Test", "ForwardDiff", "StaticArrays", "Symbolics", "LinearSolve", "Random", "LinearAlgebra", "Zygote", "SparseDiffTools", "NonlinearProblemLibrary", "LeastSquaresOptim", "FastLevenbergMarquardt", "NaNMath", "BandedMatrices", "DiffEqBase", "StableRNGs", "MINPACK", "NLsolve", "OrdinaryDiffEq", "SpeedMapping", "FixedPointAcceleration", "SIAMFANLEquations", "Sundials"]
1 change: 0 additions & 1 deletion docs/src/tutorials/large_systems.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ The resulting `NonlinearProblem` definition is:

```@example ill_conditioned_nlprob
using NonlinearSolve, LinearAlgebra, SparseArrays, LinearSolve, SparseDiffTools
import PolyesterForwardDiff
const N = 32
const xyd_brusselator = range(0, stop = 1, length = N)
Expand Down
7 changes: 0 additions & 7 deletions ext/NonlinearSolvePolyesterForwardDiffExt.jl

This file was deleted.

9 changes: 1 addition & 8 deletions src/internal/helpers.jl
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,7 @@ function get_concrete_forward_ad(autodiff, prob, sp::Val{test_sparse} = True, ar
use_sparse_ad ? AutoSparseFiniteDiff() : AutoFiniteDiff()
else
tag = ForwardDiff.Tag(NonlinearSolveTag(), eltype(prob.u0))
if use_sparse_ad
AutoSparseForwardDiff(; tag) # Polyester Sparse Mode is not implemented yet
elseif is_extension_loaded(Val(:PolyesterForwardDiff)) &&
!(prob.u0 isa Number || prob.u0 isa SArray)
AutoPolyesterForwardDiff()
else
AutoForwardDiff(; tag)
end
(use_sparse_ad ? AutoSparseForwardDiff : AutoForwardDiff)(; tag)
end
return ad
end
Expand Down

0 comments on commit c9f7d3c

Please sign in to comment.