fixed gradient and GN Hessian approximation

SciML · Nov 18, 2023 · 9387e5f · 9387e5f
1 parent 2ad0b37
commit 9387e5f
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/lib/SimpleNonlinearSolve/src/trustRegion.jl b/lib/SimpleNonlinearSolve/src/trustRegion.jl
@@ -134,8 +134,8 @@ function SciMLBase.__solve(prob::NonlinearProblem,
     end
 
     fₖ = 0.5 * norm(F)^2
-    H = ∇f * ∇f
-    g = ∇f * F
+    H = ∇f' * ∇f
+    g = ∇f' * F
     shrink_counter = 0
 
     for k in 1:maxiters
@@ -188,8 +188,8 @@ function SciMLBase.__solve(prob::NonlinearProblem,
                 Δ = min(t₂ * Δ, Δₘₐₓ)
             end
             fₖ = fₖ₊₁
-            H = ∇f * ∇f
-            g = ∇f * F
+            H = ∇f' * ∇f
+            g = ∇f' * F
         end
     end
     return SciMLBase.build_solution(prob, alg, x, F; retcode = ReturnCode.MaxIters)