Add more solvers to GPU testing

SciML · Oct 23, 2023 · 6e0911c · 6e0911c
1 parent 417701c
commit 6e0911c
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 6 deletions.
diff --git a/src/broyden.jl b/src/broyden.jl
@@ -66,8 +66,8 @@ function SciMLBase.__init(prob::NonlinearProblem{uType, iip}, alg::GeneralBroyde
                       alg.reset_tolerance
     reset_check = x -> abs(x) ≤ reset_tolerance
     return GeneralBroydenCache{iip}(f, alg, u, _mutable_zero(u), fu, zero(fu),
-        zero(fu), p, J⁻¹, zero(_vec(fu)'), _mutable_zero(u), false, 0, alg.max_resets,
-        maxiters, internalnorm, ReturnCode.Default, abstol, reset_tolerance,
+        zero(fu), p, J⁻¹, zero(reshape(fu, 1, :)), _mutable_zero(u), false, 0,
+        alg.max_resets, maxiters, internalnorm, ReturnCode.Default, abstol, reset_tolerance,
         reset_check, prob, NLStats(1, 0, 0, 0, 0),
         init_linesearch_cache(alg.linesearch, f, u, p, fu, Val(iip)))
 end

diff --git a/src/gaussnewton.jl b/src/gaussnewton.jl
@@ -82,7 +82,7 @@ function SciMLBase.__init(prob::NonlinearLeastSquaresProblem{uType, iip}, alg_::
     alg = get_concrete_algorithm(alg_, prob)
     @unpack f, u0, p = prob
 
-    if !needs_square_A(alg.linsolve) && !(u isa Number) && !(u isa StaticArray)
+    if !needs_square_A(alg.linsolve) && !(u0 isa Number) && !(u0 isa StaticArray)
         linsolve_with_JᵀJ = Val(false)
     else
         linsolve_with_JᵀJ = Val(true)

diff --git a/src/lbroyden.jl b/src/lbroyden.jl
@@ -249,12 +249,12 @@ end
         return nothing
     end
     mul!(xᵀVᵀ[:, 1:η], x', Vᵀ)
-    mul!(y', xᵀVᵀ[:, 1:η], U)
+    mul!(reshape(y, 1, :), xᵀVᵀ[:, 1:η], U)
     return nothing
 end
 
 @views function __lbroyden_rmatvec(U::AbstractMatrix, Vᵀ::AbstractMatrix, x::AbstractVector)
     # Computes xᵀ × Vᵀ × U
     size(U, 1) == 0 && return x
-    return (x' * Vᵀ) * U
+    return (reshape(x, 1, :) * Vᵀ) * U
 end
diff --git a/test/gpu.jl b/test/gpu.jl
@@ -1,5 +1,7 @@
 using CUDA, NonlinearSolve
 
+CUDA.allowscalar(false)
+
 A = cu(rand(4, 4))
 u0 = cu(rand(4))
 b = cu(rand(4))
@@ -9,4 +11,23 @@ function f(du, u, p)
 end
 
 prob = NonlinearProblem(f, u0)
-sol = solve(prob, NewtonRaphson())
+
+# TrustRegion is broken
+# LimitedMemoryBroyden will diverge!
+for alg in (NewtonRaphson(), LevenbergMarquardt(; linsolve = QRFactorization()),
+    PseudoTransient(; alpha_initial = 10.0f0), GeneralKlement(), GeneralBroyden(),
+    LimitedMemoryBroyden())
+    @test_nowarn sol = solve(prob, alg; abstol = 1.0f-8, reltol = 1.0f-8)
+end
+
+f(u, p) = A * u .+ b
+
+prob = NonlinearProblem{false}(f, u0)
+
+# TrustRegion is broken
+# LimitedMemoryBroyden will diverge!
+for alg in (NewtonRaphson(), LevenbergMarquardt(; linsolve = QRFactorization()),
+    PseudoTransient(; alpha_initial = 10.0f0), GeneralKlement(), GeneralBroyden(),
+    LimitedMemoryBroyden())
+    @test_nowarn sol = solve(prob, alg; abstol = 1.0f-8, reltol = 1.0f-8)
+end