All polyalg in 23 test problems

SciML · Mar 5, 2024 · 5911835 · 5911835
1 parent 75c0fb6
commit 5911835
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/src/algorithms/lbroyden.jl b/src/algorithms/lbroyden.jl
@@ -159,8 +159,8 @@ function LinearAlgebra.mul!(y::AbstractVector, x::AbstractVector, J::BroydenLowR
     return y
 end
 
-function LinearAlgebra.mul!(
-        J::BroydenLowRankJacobian, u, vᵀ::LinearAlgebra.AdjOrTransAbsVec, α::Bool, β::Bool)
+function LinearAlgebra.mul!(J::BroydenLowRankJacobian, u::AbstractArray,
+        vᵀ::LinearAlgebra.AdjOrTransAbsVec, α::Bool, β::Bool)
     @assert α & β
     idx_update = mod1(J.idx + 1, size(J.U, 2))
     copyto!(@view(J.U[:, idx_update]), _vec(u))

diff --git a/test/core/23_test_problems_tests.jl b/test/core/23_test_problems_tests.jl
@@ -40,6 +40,16 @@ end
 export test_on_library, problems, dicts
 end
 
+@testitem "PolyAlgorithms" setup=[RobustnessTesting] begin
+    alg_ops = (RobustMultiNewton(), FastShortcutNonlinearPolyalg())
+
+    broken_tests = Dict(alg => Int[] for alg in alg_ops)
+    broken_tests[alg_ops[1]] = []
+    broken_tests[alg_ops[2]] = []
+
+    test_on_library(problems, dicts, alg_ops, broken_tests)
+end
+
 @testitem "NewtonRaphson" setup=[RobustnessTesting] begin
     alg_ops = (NewtonRaphson(),)
 
@@ -91,7 +101,7 @@ end
     test_on_library(problems, dicts, alg_ops, broken_tests)
 end
 
-@testitem "Broyden" retries=5 setup=[RobustnessTesting] begin
+@testitem "Broyden" setup=[RobustnessTesting] begin
     alg_ops = (Broyden(), Broyden(; init_jacobian = Val(:true_jacobian)),
         Broyden(; update_rule = Val(:bad_broyden)),
         Broyden(; init_jacobian = Val(:true_jacobian), update_rule = Val(:bad_broyden)))