Change ReturnCodes from SciMLBase

SciML · Oct 24, 2022 · 2e26ff2 · 2e26ff2
1 parent a737b3e
commit 2e26ff2
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 11 deletions.
diff --git a/src/bisection.jl b/src/bisection.jl
@@ -35,7 +35,7 @@ function perform_step(solver::BracketingImmutableSolver, alg::Bisection, cache)
 
         if left == mid || right == mid
             @set! solver.force_stop = true
-            @set! solver.retcode = ReturnCode.Success
+            @set! solver.retcode = ReturnCode.FloatingPointLimit
             return solver
         end
 

diff --git a/src/falsi.jl b/src/falsi.jl
@@ -21,7 +21,7 @@ function perform_step(solver, alg::Falsi, cache)
 
     if right == mid || right == mid
         @set! solver.force_stop = true
-        @set! solver.retcode = ReturnCode.Success
+        @set! solver.retcode = ReturnCode.FloatingPointLimit
         return solver
     end
 
@@ -32,7 +32,7 @@ function perform_step(solver, alg::Falsi, cache)
         @set! solver.force_stop = true
         @set! solver.left = mid
         @set! solver.fl = fm
-        @set! solver.retcode = ReturnCode.Success
+        @set! solver.retcode = ReturnCode.ExactSolutionLeft
     else
         if sign(fm) == sign(fl)
             @set! solver.left = mid

diff --git a/src/scalar.jl b/src/scalar.jl
@@ -109,7 +109,7 @@ function SciMLBase.solve(prob::NonlinearProblem, alg::Bisection, args...; maxite
 
     if iszero(fl)
         return SciMLBase.build_solution(prob, alg, left, fl;
-                                        retcode = ReturnCode.Success, left = left,
+                                        retcode = ReturnCode.ExactSolutionLeft, left = left,
                                         right = right)
     end
 
@@ -119,7 +119,7 @@ function SciMLBase.solve(prob::NonlinearProblem, alg::Bisection, args...; maxite
             mid = (left + right) / 2
             (mid == left || mid == right) &&
                 return SciMLBase.build_solution(prob, alg, left, fl;
-                                                retcode = ReturnCode.Success,
+                                                retcode = ReturnCode.FloatingPointLimit,
                                                 left = left, right = right)
             fm = f(mid)
             if iszero(fm)
@@ -141,7 +141,7 @@ function SciMLBase.solve(prob::NonlinearProblem, alg::Bisection, args...; maxite
         mid = (left + right) / 2
         (mid == left || mid == right) &&
             return SciMLBase.build_solution(prob, alg, left, fl;
-                                            retcode = ReturnCode.Success,
+                                            retcode = ReturnCode.FloatingPointLimit,
                                             left = left, right = right)
         fm = f(mid)
         if iszero(fm)
@@ -166,7 +166,7 @@ function SciMLBase.solve(prob::NonlinearProblem, alg::Falsi, args...; maxiters =
 
     if iszero(fl)
         return SciMLBase.build_solution(prob, alg, left, fl;
-                                        retcode = ReturnCode.Success, left = left,
+                                        retcode = ReturnCode.ExactSolutionLeft, left = left,
                                         right = right)
     end
 
@@ -175,7 +175,7 @@ function SciMLBase.solve(prob::NonlinearProblem, alg::Falsi, args...; maxiters =
         while i < maxiters
             if nextfloat_tdir(left, prob.u0...) == right
                 return SciMLBase.build_solution(prob, alg, left, fl;
-                                                retcode = ReturnCode.Success,
+                                                retcode = ReturnCode.FloatingPointLimit,
                                                 left = left, right = right)
             end
             mid = (fr * left - fl * right) / (fr - fl)
@@ -205,7 +205,7 @@ function SciMLBase.solve(prob::NonlinearProblem, alg::Falsi, args...; maxiters =
         mid = (left + right) / 2
         (mid == left || mid == right) &&
             return SciMLBase.build_solution(prob, alg, left, fl;
-                                            retcode = ReturnCode.Success,
+                                            retcode = ReturnCode.FloatingPointLimit,
                                             left = left, right = right)
         fm = f(mid)
         if iszero(fm)

diff --git a/src/solve.jl b/src/solve.jl
@@ -89,10 +89,10 @@ function mic_check(solver::BracketingImmutableSolver)
     (flr > fzero) && error("Non bracketing interval passed in bracketing method.")
     if fl == fzero
         @set! solver.force_stop = true
-        @set! solver.retcode = Retcode.Success
+        @set! solver.retcode = Retcode.ExactSolutionLeft
     elseif fr == fzero
         @set! solver.force_stop = true
-        @set! solver.retcode = Retcode.Success
+        @set! solver.retcode = Retcode.ExactionSolutionRight
     end
     solver
 end