Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Optional unit rewriting #1252

Closed
wants to merge 11 commits into from
Closed

[WIP] Optional unit rewriting #1252

wants to merge 11 commits into from

Commits on Sep 6, 2021

  1. Experiment with having unit rewriting alongside original unit checking.

    Lucas Morton committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    91429e5 View commit details
    Browse the repository at this point in the history

  2. Fix bug in conditional validation.

    Lucas Morton committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    9dd1904 View commit details
    Browse the repository at this point in the history

  3. Need to use Constants so that get_unit will work correctly after re… 

    …write (although that should be avoided anyway b/c the rewrite will post the top-level unit and `get_unit` can just check for this first now). It is also helpful for debugging/comprehension to see the conversion factors with units.
    Lucas Morton committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    191cbac View commit details
    Browse the repository at this point in the history

  4. Dropping trig functions b/c even though I could handle them now, `get… 

    …_unit` still won't validate them correctly.
    Lucas Morton committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    246c9f3 View commit details
    Browse the repository at this point in the history

  5. Added debug flag to rewrite_units.

    Lucas Morton committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    3cb883c View commit details
    Browse the repository at this point in the history

  6. Remembered I need to handle roots.

    Lucas Morton committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    2dc5b92 View commit details
    Browse the repository at this point in the history

  7. We might save a bunch of work by short-circuiting here: just see if t… 

    …he units work out correctly on their own.
    Lucas Morton committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    1198ece View commit details
    Browse the repository at this point in the history

  8. Reformatting/comments.

    Lucas Morton committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    3c36e78 View commit details
    Browse the repository at this point in the history

  9. Added some rewrite tests.

    Lucas Morton committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    31faede View commit details
    Browse the repository at this point in the history

  10. Should be able to skip this too, now that we're using safe_get_unit u… 

    …p front.
    Lucas Morton committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    2d8ed11 View commit details
    Browse the repository at this point in the history

  11. Cleanup.

    Lucas Morton committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    6e134a2 View commit details
    Browse the repository at this point in the history