Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle LU failure and Symmetric QR #494

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Handle LU failure and Symmetric QR #494

merged 2 commits into from
Apr 25, 2024

Conversation

avik-pal
Copy link
Member

Sorry for the bad diff, there was a bad windows code that was merged which changed all the line endings

  • Fixes QR for symmetric matrices
  • LU also early terminates now (not sure why we have 2 copies of solve! and do_factorization, which can be merged together with a different abstraction?)

Let's wait for SciML/NonlinearSolve.jl#414 to be finished.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 62.71%. Comparing base (4afec5a) to head (de29257).

Files Patch % Lines
src/factorization.jl 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #494      +/-   ##
==========================================
- Coverage   62.85%   62.71%   -0.14%     
==========================================
  Files          29       29              
  Lines        2221     2229       +8     
==========================================
+ Hits         1396     1398       +2     
- Misses        825      831       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal
Copy link
Member Author

Let #495 go in first

@avik-pal
Copy link
Member Author

This PR will be readable after that is in

@ChrisRackauckas ChrisRackauckas merged commit f5282e5 into main Apr 25, 2024
14 of 18 checks passed
@ChrisRackauckas ChrisRackauckas deleted the ap/fact_sym branch April 25, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants