Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ChainRulesCore.rrule for constructors and getproperty #107

Merged
merged 6 commits into from
Nov 22, 2021

Conversation

torfjelde
Copy link
Contributor

This PR adds AD rules for:

  • LArray{syms}
  • SLArray{size,syms}
  • getproperty

This all the issues in #91 with the exception of the ForwardDiff.jl-issue for SLArray.

Some things of note/questions to address:

  • Are there more constructors we need to add implementations for? There are quite a few constructors, but it's a bit unclear which we need custom rules for atm. For example it might be nice to have rules defined for LVector(::NamedTuple), which currently does not work.

@ChrisRackauckas ChrisRackauckas merged commit fdca936 into SciML:master Nov 22, 2021
@ChrisRackauckas
Copy link
Member

Awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants