Fix #242 : Pass IntegralProblem kwargs to solvers #244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Fixes #242 . I first looked at how SimpleNonlinearSolve.jl does this and basically came up with the most simple solution to match. I also bumped the SciMLBase.jl version since otherwise some disallowed solver kwargs, like
nout
andbatch
, could potentially cause errors. (This scenario would be unlikely, i.e. someone mixing the oldnout/batch
interface with the newIntegralFunction
interface, but I would rather avoid any errors if possible, which SciML/SciMLBase.jl#609 helped with by making it impossible fornout/batch
to get stored asprob.kwargs
.)