-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArrayInterface integration #25
Conversation
Can you up the version and test bounds to v1.5? |
I assume you wanted me to also update the projects Julia dep to 1.5 |
test/Project.toml
Outdated
@@ -0,0 +1,3 @@ | |||
[deps] | |||
ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't needed here since it's in the project
Thanks! |
Any chance this could be done via a glue package? ("Oh, just gimmee that type piracy 𝅘𝅥𝅮 𝅘𝅥𝅮 𝅘𝅥𝅮...") Or maybe even flip the dependencies, and make ArrayInterface import EllipsisNotation? See JuliaMath/IntervalSets.jl#57 (comment). |
I'm not against having ArrayInterface.jl depend on EllipsisNotation.jl, but isn't the point of ArrayInterface.jl to have things depend on it? We already have about ~300 lines of code that are just using |
Can you clarify what |
Yes |
Gotcha. I see that it is in the documentation for this package, sorry. This package does clearly spell out that this usage is for arrays, and so perhaps it was a mistake on IntervalSet's part to try to incorporate it. It is a bit unfortunate that the twin uses (for indexing and constructing intervals, much like I guess one option would be to split out a package called |
This kind of issue is part of what has resulted in a bunch of partially functioning successors to I have been (and will continue to) clean up code and document more of ArrayInterface. Also, there's a possibility that overtime more traits will move to base. I've tried to explain elsewhere that this means an increasing portion of the lines there are going to be low maintenance documentation, but at the end of the day people just don't like to depend on stuff. EDIT: Apologies if this comment was more of a rant than a productive thought. My opinion is to just leave it as is because there will always be someone that wants a single line of code out of the 1,000; so don't worry about pleasing everyone. On the other hand, I'm not the package author here so I'll go along with whatever is decided without grumbling (anymore than I already have). |
I'm not sure if you want this package to depend on ArrayInterface.jl or the other way around, but this is at least a start for getting
..
as part of the the new indexing pipeline in ArrayInterface.