Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "StaticArrays" to "1.0" #604

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the StaticArrays package from 0.11, 0.12 to 0.11, 0.12, 1.0.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@devmotion
Copy link
Member

It seems CompatHelper does not have the correct permission to start the Github tests. Probably missing a deploy key: https://github.com/JuliaRegistries/CompatHelper.jl#12-set-up-the-ssh-deploy-key-optional

@ranocha
Copy link
Member

ranocha commented Dec 4, 2020

It would be nice to run the tests here to allow downstream packages to run tests when bumping their version bounds for StaticArrays.jl. For example, we depend on DiffEqBase.jl in Trixi.jl but cannot run tests using StaticArrays.jl v1.0 because of DiffEqBase.jl, see trixi-framework/Trixi.jl#360.

@devmotion devmotion closed this Dec 4, 2020
@devmotion devmotion reopened this Dec 4, 2020
@devmotion
Copy link
Member

The tests still don't run with StaticArrays 1.0, it seems some dependency holds it back.

@ranocha
Copy link
Member

ranocha commented Dec 4, 2020

The tests still don't run with StaticArrays 1.0, it seems some dependency holds it back.

Yes, it's NonlinearSolve.jl and others. I've made some PRs (SciML/NonlinearSolve.jl#16, RecursiveArrayTools.jl (SciML/RecursiveArrayTools.jl#123)).

@ChrisRackauckas
Copy link
Member

Yeah sorry, this whole thing got lost because we had to switch to Github Actions the week that we got these CompatHelper PRs... so I think I archived a ton of emails before they were actually completed. Everything got to GHA, but not everything got the CompatHelper completed.

@ranocha
Copy link
Member

ranocha commented Dec 4, 2020

Yeah sorry, this whole thing got lost because we had to switch to Github Actions the week that we got these CompatHelper PRs... so I think I archived a ton of emails before they were actually completed. Everything got to GHA, but not everything got the CompatHelper completed.

No problem. We got the momentum back and you're handling this pretty fast, so everything is fine from my side.

@ChrisRackauckas ChrisRackauckas merged commit 023917f into master Dec 4, 2020
@ChrisRackauckas ChrisRackauckas deleted the compathelper/new_version/2020-11-27-09-10-51-451-712828370 branch December 4, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants