Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenter 1.0 upgrade #99

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Documenter 1.0 upgrade #99

merged 1 commit into from
Sep 24, 2023

Conversation

ArnoStrouwen
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Merging #99 (c99e132) into main (aa96fd8) will increase coverage by 8.89%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   89.02%   97.92%   +8.89%     
==========================================
  Files           9        9              
  Lines         237      241       +4     
==========================================
+ Hits          211      236      +25     
+ Misses         26        5      -21     

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ArnoStrouwen
Copy link
Member Author

@mortenpi I don't think this error was there on the Documenter 0.27. Could you have a look?
https://github.com/SciML/DeepEquilibriumNetworks.jl/actions/runs/6287038330/job/17071104030?pr=99#step:5:13

@mortenpi
Copy link

mortenpi commented Sep 24, 2023

That's from DocumenterCitations, which I'm not that familiar with. But the error looks like that either you have a missing bibliography entry or a typo in a bibliography reference?

Oh, scratch that(*). You need to pass the plugin via the plugins = keyword now (JuliaDocs/Documenter.jl#2249).

(*) And also fix the reference probably, but that's not causing the failure.

@ArnoStrouwen
Copy link
Member Author

Looks good now except for the Lux link that needs to be fixed in SciMLDocs:
SciML/SciMLDocs#180

@ChrisRackauckas ChrisRackauckas merged commit 30cdb93 into SciML:main Sep 24, 2023
@ArnoStrouwen ArnoStrouwen deleted the docs1 branch September 24, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants