Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache incidence matrix #975

Merged
merged 17 commits into from
Jul 12, 2024
Merged

Cache incidence matrix #975

merged 17 commits into from
Jul 12, 2024

Conversation

vyudu
Copy link
Collaborator

@vyudu vyudu commented Jul 9, 2024

For functions that use the incidence matrix (isreversible, isweaklyreversible, deficiency, linkageclasses, etc.) have them construct the incidence matrix internally instead of having the user call reactioncomplexes first.

src/network_analysis.jl Outdated Show resolved Hide resolved
Copy link
Member

@isaacsas isaacsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to update the docstrings of any functions that now handle caching (which may mention users previously needed to call reactioncomplexes first...). For example, incidencematgraph.

@isaacsas isaacsas merged commit 68c0664 into SciML:master Jul 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants