Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14 - Ready] Go through broken tests #930

Merged
merged 9 commits into from
Jun 10, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
up
  • Loading branch information
TorkelE committed Jun 9, 2024
commit 36d2e178ea87c0fa8807e68da5e23e7783dd7d22
2 changes: 1 addition & 1 deletion test/reactionsystem_core/events.jl
Original file line number Diff line number Diff line change
@@ -158,7 +158,7 @@ let
]

# Declares various misformatted events .
# Relevant MTK issue regarding misformatted events not throwing an early error https://github.com/SciML/ModelingToolkit.jl/issues/2612.
@test_broken false # Some missformatted tests should throw error at this stage, but does not (https://github.com/SciML/ModelingToolkit.jl/issues/2612).
TorkelE marked this conversation as resolved.
Show resolved Hide resolved
continuous_events_bad = [
X ~ 1.0 => [X ~ 0.5], # Scalar condition.
[X ~ 1.0] => X ~ 0.5, # Scalar affect.
4 changes: 2 additions & 2 deletions test/reactionsystem_core/reactionsystem.jl
Original file line number Diff line number Diff line change
@@ -235,7 +235,7 @@ let
maj = MassActionJump(symmaj.param_mapper(pars), symmaj.reactant_stoch, symmaj.net_stoch,
symmaj.param_mapper, scale_rates = false)
for i in midxs
@test_broken abs(jumps[i].scaled_rates - maj.scaled_rates[i]) < 100 * eps()
@test_broken abs(jumps[i].scaled_rates - maj.scaled_rates[i]) < 100 * eps() # This (and next two) tests are broken due to the order in `maj` not being preserved.
@test jumps[i].reactant_stoch == maj.reactant_stoch[i]
@test jumps[i].net_stoch == maj.net_stoch[i]
end
@@ -747,5 +747,5 @@ end
# there are several places in the code where the `reactionsystem_uptodate` function is called, here
# the code might need adaptation to take the updated reaction system into account.
let
@test_nowarn Catalyst.reactionsystem_uptodate_check()
@test_nowarn Catalyst.reactionsystem_uptodate_check()
end
1 change: 0 additions & 1 deletion test/upstream/mtk_problem_inputs.jl
Original file line number Diff line number Diff line change
@@ -230,7 +230,6 @@ let
if (ps == ps_valid) && (u0 == u0_valid)
XProblem(xsys, u0, (0.0, 1.0), ps); @test true;
else
# Several of these cases do not throw errors (https://github.com/SciML/ModelingToolkit.jl/issues/2624).
@test_broken false
continue
@test_throws Exception XProblem(xsys, u0, (0.0, 1.0), ps)