-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use NonlinearSolveFirstOrder subpackages and use new CI #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qingyu Qu <[email protected]>
Signed-off-by: Qingyu Qu <[email protected]>
Alright, this PR is done, I can open a new PR to clean the git history. Seems BVPM2 wrapper error about Error in testset "BVPM2" on worker 8969:
Error During Test at /home/runner/work/BoundaryValueDiffEq.jl/BoundaryValueDiffEq.jl/test/wrappers/odeinterface_tests.jl:32
Got exception outside of a @test
StackOverflowError:
Stacktrace:
[1] bvpm2_solve(guess_obj::ODEInterface.Bvpm2, rhs::Function, bc::Function, opt::ODEInterface.OptionsODE; Drhs::Nothing, Dbc::Nothing)
@ ODEInterface ~/.julia/packages/ODEInterface/RwRLn/src/Bvpm2.jl:1240
[2] bvpm2_solve
@ ~/.julia/packages/ODEInterface/RwRLn/src/Bvpm2.jl:1155 [inlined]
[3] __solve(prob::SciMLBase.BVProblem{Vector{Float64}, Tuple{Float64, Float64}, true, false, Vector{Float64}, SciMLBase.BVPFunction{true, SciMLBase.FullSpecialize, true, typeof(Main.var"##ODEInterfaceWrapperTestSetup#230".ex7_f!), Tuple{typeof(Main.var"##ODEInterfaceWrapperTestSetup#230".ex7_2pbc1!), typeof(Main.var"##ODEInterfaceWrapperTestSetup#230".ex7_2pbc2!)}, LinearAlgebra.UniformScaling{Bool}, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, RecursiveArrayTools.ArrayPartition{Float64, Tuple{Vector{Float64}, Vector{Float64}}}, Nothing, Nothing, Nothing, Nothing, typeof(SciMLBase.DEFAULT_OBSERVED), Nothing, Nothing, SymbolicIndexingInterface.SymbolCache{Nothing, Nothing, Nothing, Nothing, Dict{Any, Any}}, Nothing}, SciMLBase.TwoPointBVProblem{true}, @Kwargs{}}, alg::BoundaryValueDiffEq.BVPM2{Nothing}; dt::Float64, reltol::Float64, kwargs::@Kwargs{})
@ BoundaryValueDiffEqODEInterfaceExt ~/work/BoundaryValueDiffEq.jl/BoundaryValueDiffEq.jl/ext/BoundaryValueDiffEqODEInterfaceExt.jl:85
[4] __solve
@ ~/work/BoundaryValueDiffEq.jl/BoundaryValueDiffEq.jl/ext/BoundaryValueDiffEqODEInterfaceExt.jl:26 [inlined]
[5] #solve_call#44
@ ~/.julia/packages/DiffEqBase/HW4ge/src/solve.jl:632 [inlined]
[6] solve_call
@ ~/.julia/packages/DiffEqBase/HW4ge/src/solve.jl:589 [inlined]
[7] #solve_up#53
@ ~/.julia/packages/DiffEqBase/HW4ge/src/solve.jl:1120 [inlined]
[8] solve_up
@ ~/.julia/packages/DiffEqBase/HW4ge/src/solve.jl:1099 [inlined]
[9] #solve#51
@ ~/.julia/packages/DiffEqBase/HW4ge/src/solve.jl:1036 [inlined]
[10] top-level scope
@ ~/work/BoundaryValueDiffEq.jl/BoundaryValueDiffEq.jl/test/wrappers/odeinterface_tests.jl:38
[11] eval
@ ./boot.jl:430 [inlined]
[12] #93
@ ~/.julia/packages/ReTestItems/ecp6j/src/ReTestItems.jl:1067 [inlined]
[13] with_source_path(f::ReTestItems.var"#93#97"{Expr}, path::String)
@ ReTestItems ~/.julia/packages/ReTestItems/ecp6j/src/ReTestItems.jl:885
[14] (::ReTestItems.var"#92#96"{TestItem, String, Expr, Expr})()
@ ReTestItems ~/.julia/packages/ReTestItems/ecp6j/src/ReTestItems.jl:1067
[15] redirect_stdio(f::ReTestItems.var"#92#96"{TestItem, String, Expr, Expr}; stdin::Nothing, stderr::IOContext{IOStream}, stdout::IOContext{IOStream})
@ Base ./stream.jl:1439
[16] redirect_stdio
@ ./stream.jl:1402 [inlined]
[17] _redirect_logs(f::ReTestItems.var"#92#96"{TestItem, String, Expr, Expr}, target::IOStream)
@ ReTestItems ~/.julia/packages/ReTestItems/ecp6j/src/log_capture.jl:124
[18] #31
@ ~/.julia/packages/ReTestItems/ecp6j/src/log_capture.jl:107 [inlined]
[19] open(::ReTestItems.var"#31#32"{ReTestItems.var"#92#96"{TestItem, String, Expr, Expr}}, ::String, ::Vararg{String}; kwargs::@Kwargs{})
@ Base ./io.jl:410
[20] open
@ ./io.jl:407 [inlined]
[21] _redirect_logs
@ ~/.julia/packages/ReTestItems/ecp6j/src/log_capture.jl:107 [inlined]
[22] macro expansion
@ ~/.julia/packages/ReTestItems/ecp6j/src/macros.jl:82 [inlined]
[23] runtestitem(ti::TestItem, ctx::ReTestItems.TestContext; test_end_expr::Expr, logs::Symbol, verbose_results::Bool, finish_test::Bool, catch_test_error::Bool, failfast::Bool)
@ ReTestItems ~/.julia/packages/ReTestItems/ecp6j/src/ReTestItems.jl:1064
[24] top-level scope
@ none:1
[25] eval
@ ./boot.jl:430 [inlined]
[26] execute
@ ~/.julia/packages/ReTestItems/ecp6j/src/workers.jl:332 [inlined]
[27] (::ReTestItems.Workers.var"#22#23"{Sockets.TCPSocket, ReentrantLock, ReTestItems.Workers.Request})()
@ ReTestItems.Workers ~/.julia/packages/ReTestItems/ecp6j/src/workers.jl:346 while the wrappers algorithms have not been touched, I am not sure where this problem come from, also this error can't be reproduced in a local environment🤔 |
Expanded seem to fail? |
Should be ready now |
Remember to tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #242
Fix: #243
Fix: #244
This PR should be able to fix lots of things:
__unsafe_nonlinearfunction
and useNonlinearFunction
everywherevalstr
for the next iteration error estimate when the mesh is doubled, and a new test case is added