-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor FIRK solvers #211
Conversation
ErikQQY
commented
Sep 12, 2024
- Add precompilation options for Lobatto and Radau solvers, but precompiling all of them seems to take a long time, so just set them as false for now
- Previous tolerance for nested nonlinear solving is bad, change it to nothing as default so that NonlinearSolve.jl can choose automatically
- Some variables and functions in some functions are not used, so cleaned up a little
- Some functions are not optimal, improve their performance
- Unify the interpolant evaluation for MIRK and FIRK methods
Signed-off-by: ErikQQY <[email protected]>
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Signed-off-by: ErikQQY <[email protected]>
Signed-off-by: ErikQQY <[email protected]>
You should probably just split it to a subpackage, i.e. lib/BoundaryDiffEqFIRK, and then you can set it to precompile, but it does not have to be in the standard BounaryDiffEq load. The plan should be to do this split with all of the solvers. |
Signed-off-by: ErikQQY <[email protected]>
Yeah, splitting BoundaryValueDiffEq.jl into subpackages like what we've done in OrdinaryDiffEq.jl is on my TODO list, so let's leave the precompile stuff into splitting part and get the others in? Since the Shooting, MIRK and FIRK are separately implemented in BoundaryValueDiffEq.jl, I can get that done today |
Signed-off-by: ErikQQY <[email protected]>