Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmarks CI #198

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Fix benchmarks CI #198

merged 2 commits into from
Jul 23, 2024

Conversation

ErikQQY
Copy link
Member

@ErikQQY ErikQQY commented Jul 22, 2024

Nonlinear solvers should be specified when using Shooting methods

ErikQQY added 2 commits July 22, 2024 15:57
Signed-off-by: ErikQQY <[email protected]>
Signed-off-by: ErikQQY <[email protected]>
@ErikQQY
Copy link
Member Author

ErikQQY commented Jul 22, 2024

This PR should be ready to go

@avik-pal
Copy link
Member

Seems to fail?

@ErikQQY
Copy link
Member Author

ErikQQY commented Jul 23, 2024

I think maybe the CI will work only after PR is merged? I tested locally and the benchmarking scripts are working:

image

@ChrisRackauckas
Copy link
Member

let's try it

@ChrisRackauckas ChrisRackauckas merged commit d9bc98d into SciML:master Jul 23, 2024
4 of 6 checks passed
@ErikQQY ErikQQY deleted the qqy/fix_benchmark branch July 23, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants