Minor Updates to Multiple Shooting #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/ms_improvements
branch
from
7690a3d to
17e25e9
Compare
avik-pal
force-pushed
the
ap/ms_improvements
branch
from
17e25e9 to
f171153
Compare
avik-pal
changed the title
avik-pal
force-pushed
the
ap/ms_improvements
branch
from
2320bf7 to
08ff66a
Compare
22 tasks
| @@ -236,7 +231,7 @@ function __solve(prob::BVProblem, _alg::MultipleShooting; odesolve_kwargs = (;), | |||
| nodes); resid_prototype, jac = jac_fn, jac_prototype) | |||
| nlprob = NonlinearProblem(loss_function!, u_at_nodes, prob.p) | |||
| sol_nlsolve = __solve(nlprob, alg.nlsolve; nlsolve_kwargs..., verbose, kwargs...) | |||
| # u_at_nodes = sol_nlsolve.u | |||
| u_at_nodes = sol_nlsolve.u::typeof(u0) | |||
There was a problem hiding this comment.
why is the type assert needed?
There was a problem hiding this comment.
I tried figuring out where the exact type instability is coming from, but Cthulhu also breaks down...
ChrisRackauckas
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.