-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
I think we could improve that by checking if input is bam or fastq, and then do the correct thing |
I'm now happy with my latest changes. |
The only thing that is really missing is tests for this new feature... |
|
||
output: | ||
file "*_fastqc.{zip,html}" into fastQCreport | ||
|
||
when: step == 'mapping' && !params.noReports | ||
|
||
script: | ||
inputFiles = SarekUtils.hasExtension(inputFile1,"fastq.gz") ? "${inputFile1} ${inputFile2}" : "${inputFile1}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably allow fq.gz as well right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can think of it in the extractSample() function, but currently I can't think of anyone asking me about this particular .fq.gz
extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the BAM index files in the tsv file example?
The index is not in the TSV when mapping BAMs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK
fastqFiles
renamed toinputFiles
MapReads
forremapping
will now convert BAM to FASTQ and feed it to BWA on the flyPR checklist
dev
branch./scripts/test.sh -p docker -t ALL
).docs
is updatedCHANGELOG.md
is updated