feat(OnyxSelect): update the hover and focus colors of the chevron icon #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c18184d The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoCa96
requested changes
Dec 2, 2024
Where do you seethe complexity in this PR? Imo, the main changes are the screenshots which are only changed because the select chevron color changed in Figma which we need to implement anyways, independent from the date picker. The date picker just uses the same icon styles as the select |
larsrickert
force-pushed
the
feat/1818-datepicker-icon
branch
from
583da4f to
7f62493
Compare
larsrickert
changed the title
JoCa96
approved these changes
Dec 4, 2024
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: larsrickert <[email protected]>
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: larsrickert <[email protected]>
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: larsrickert <[email protected]>
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: larsrickert <[email protected]>
larsrickert
force-pushed
the
feat/1818-datepicker-icon
branch
from
83b10fc to
c18184d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1818
The colors of the select chevron icon were updated in Figma. I updated them in this PR and also moved the button styles to the shared scss file so we can easily add such buttons other form elements (date picker, inputs etc.) in the future
Checklist
npx changeset addif your changes should be released as npm package (because they affect the library usage)