Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(headless): implement headless Menu #1460

Merged
merged 49 commits into from
Jul 16, 2024
Merged

feat(headless): implement headless Menu #1460

merged 49 commits into from
Jul 16, 2024

Conversation

JoCa96
Copy link
Collaborator

@JoCa96 JoCa96 commented Jul 1, 2024 •
edited
Loading

Relates to #1415, #883
Closes #1518

  • implemented headless feature: createNavigationMenu
  • headless MenuButton:
    • now takes an isExpandedRef and onToggle via it's options
    • flyout element is removed as it is not needed
    • removed hover and focus toggle features and moved them to the onyx component directly as these are non spec features

@JoCa96 JoCa96 requested a review from a team as a code owner July 1, 2024 08:03
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 5053295

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@sit-onyx/headless Major
sit-onyx Minor
demo-app Patch
playground Patch
@sit-onyx/chartjs-plugin Major
@sit-onyx/nuxt Major
@sit-onyx/storybook-utils Major
@sit-onyx/vitepress-theme Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoCa96 JoCa96 requested a review from larsrickert July 3, 2024 06:54
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 9, 2024
View reviewed changes
packages/headless/src/utils/builder.ts Dismissed Show dismissed Hide dismissed
@JoCa96 JoCa96 mentioned this pull request Jul 9, 2024
Merged
@JoCa96 JoCa96 marked this pull request as draft July 9, 2024 08:13
JoCa96 added a commit that referenced this pull request Jul 11, 2024
@JoCa96
feat(@sit-onyx/headless): implement global event listener (#1533)
2e29c45 
Some files/funcitons were added in preparation for #1460
Relates to #1518

* Rename `*.ct.ts` ts helper files to fix playwright import issue 
* Use `ref` instead of callback
* Update builder type to allow for no parameters and usage of reservered
prop `ref`
@JoCa96 JoCa96 marked this pull request as ready for review July 15, 2024 07:05
@JoCa96 JoCa96 requested review from larsrickert and removed request for larsrickert July 15, 2024 07:36
@larsrickert larsrickert merged commit c2a6447 into main Jul 16, 2024
19 checks passed
@larsrickert larsrickert deleted the joca96/1434-update-user-menu branch July 16, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsrickert larsrickert larsrickert approved these changes

Assignees

@larsrickert larsrickert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix OnyxUserMenu captures click events before they reach the actual target
3 participants
@JoCa96 @larsrickert @BoppLi