Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement additional data storybook examples for OnyxSelect options #742

Closed
11 tasks done
larsrickert opened this issue Mar 22, 2024 · 1 comment
Closed
11 tasks done

Implement additional data storybook examples for OnyxSelect options #742

larsrickert opened this issue Mar 22, 2024 · 1 comment
Assignees
@MajaZarkova
Labels
dev Requires technical expertise storybook Storybook improve- or adjustments
Milestone
Combo boxes

Comments

@larsrickert
Copy link
Collaborator

larsrickert commented Mar 22, 2024 •
edited by mj-hof
Loading

Depends on

Why?

The select option should be extended to support displaying additional data.

Design

Figma link.

Acceptance criteria

  • a badge can be shown
  • a tag can be shown
  • a suffix text can be displayed

Out of scope

  • keyboard shortcut
  • consider implementing a dedicated component for keyboard shortcuts (e.g. with a prop to switch between windows and mac style)

Definition of Done

  • covered by component tests
  • screenshot tests are updated
  • follow-up tickets were created if necessary
  • updated version + documentation is deployed
  • Storybook can show the feature
  • Set task to In Approval

Approval

Implementation details

add details if necessary, e.g.,

  • suffix text should support string values (not only keyboard shortcuts)
  • for flexibility, use slots
@larsrickert larsrickert added this to onyx Mar 22, 2024
@larsrickert larsrickert converted this from a draft issue Mar 22, 2024
@larsrickert larsrickert moved this from New to Backlog in onyx Mar 22, 2024
@larsrickert larsrickert added the dev Requires technical expertise label Mar 22, 2024
@larsrickert larsrickert mentioned this issue Mar 22, 2024
Closed
13 tasks
@larsrickert larsrickert added this to the Combo boxes milestone Mar 22, 2024
@mj-hof mj-hof moved this from Backlog to New in onyx Mar 25, 2024
@mj-hof mj-hof moved this from New to Backlog in onyx Mar 25, 2024
@larsrickert larsrickert moved this from Backlog to Ready in onyx Apr 10, 2024
@larsrickert larsrickert removed their assignment Apr 10, 2024
This was referenced Apr 22, 2024
Closed
Open
@MajaZarkova MajaZarkova self-assigned this May 20, 2024
@MajaZarkova MajaZarkova moved this from Ready to In Progress in onyx May 20, 2024
@MajaZarkova MajaZarkova removed their assignment May 20, 2024
@MajaZarkova MajaZarkova moved this from In Progress to Ready in onyx May 20, 2024
@BoppLi BoppLi self-assigned this May 29, 2024
@BoppLi BoppLi moved this from Ready to In Progress in onyx May 29, 2024
@BoppLi
Copy link
Contributor

BoppLi commented Jun 3, 2024 •
edited
Loading

Info: started in feat/742-additional-select-data, but aborted. there are plans to refactor flyout contents to be slot based. this impacts the way this feature is implemented greatly.

@BoppLi BoppLi moved this from In Progress to Ready in onyx Jun 3, 2024
@BoppLi BoppLi removed their assignment Jun 3, 2024
@BoppLi BoppLi changed the title Implement additional data for listbox option Implement additional data for OnyxSelect option Jun 3, 2024
@BoppLi BoppLi changed the title Implement additional data for OnyxSelect option Implement additional data storybook examples for OnyxSelect options Jul 3, 2024
@mj-hof mj-hof added the storybook Storybook improve- or adjustments label Oct 29, 2024
@MajaZarkova MajaZarkova moved this from Ready to In Progress in onyx Oct 29, 2024
@MajaZarkova MajaZarkova mentioned this issue Oct 29, 2024
Merged
MajaZarkova added a commit that referenced this issue Oct 30, 2024
@MajaZarkova
chore(OnyxSelect): Add new OnyxSelect storybook example (#2019)
0a301ea 
<!-- Is your PR related to an issue? Then please link it via the
"Relates to #" below. Else, remove it. -->

Relates to #742 

Added new storybook example which includes custom options with
additional data added via slot.
@MajaZarkova MajaZarkova moved this from In Progress to In Approval in onyx Oct 30, 2024
@github-project-automation github-project-automation bot moved this from In Approval to Done in onyx Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MajaZarkova MajaZarkova

Labels
dev Requires technical expertise storybook Storybook improve- or adjustments
Projects
onyx
Status: Done
Milestone
Combo boxes
Development

No branches or pull requests
4 participants
@MajaZarkova @larsrickert @BoppLi @mj-hof