Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: perform pip-downgrade before the pip-compile #39

Merged
merged 2 commits into from
Feb 1, 2022
Merged

fix: perform pip-downgrade before the pip-compile #39

merged 2 commits into from
Feb 1, 2022

Conversation

devmessias
Copy link
Contributor

@devmessias devmessias commented Jan 31, 2022 •
edited
Loading

We should replace pip-downgrade by a pip-upgrade task
after pip-tools team's solution be merged and released.

After the bug been fixed, we should have the following

pip-uprade:
	$(PYTHON_INTERPRETER) -m pip install --upgrade
	
## Install Python Dependencies & Install pre-commit hooks
requirements: pip-upgrade pip-compile check_installed_python

@devmessias
fix!: perform pip-downgrade before the pip-compile
6139a9c 
pip-downgrade should be removed
after `pip-tools` team's solution regarding pip log bug
be merged and released

Related to: jazzband/pip-tools#1558
@devmessias devmessias changed the title fix!: perform pip-downgrade before the pip-compile fix: perform pip-downgrade before the pip-compile Jan 31, 2022
@Schots Schots merged commit 6da8252 into Schots:main Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Schots Schots Schots approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devmessias @Schots