Fix linter warnings in Markdown files

.vscode/settings.json

@@ -26,5 +26,10 @@
   },
   "typescript.enablePromptUseWorkspaceTsdk": true,
   "typescript.preferences.quoteStyle": "single",
-  "prettier.prettierPath": ".yarn/sdks/prettier/index.js"
-}
+  "prettier.prettierPath": ".yarn/sdks/prettier/index.js",
+  "markdownlint.config": {
+    "no-duplicate-header": {
+      "allow_different_nesting": true
+    }
+  }
+}

CHANGELOG.md

@@ -4,6 +4,7 @@
 ## Unreleased
 
 ### Changes
+
 - Internally we now have a `subscribeToGlobalFlags` to use up-to-date global flags
   - Currently, this makes it that changing the global flags can immediately have an effect for some flags
   - Global flags are those defined in your User Settings or Workspace(Folder) Settings
@@ -31,17 +32,20 @@
   - Although this can change, for workspace folders, paths specified in the global/workspace settings are also scanned
 
 ### Development changes
+
 - Move the whole flag system from config.ts to flags.ts
 - Updated Yarn to version 3.5.0
 - Upgrade a ton of dependencies
   - Replace deprecated `vsce` with `@vscode/vsce@^2.18.0`
   - Upgrade TypeScript from ~4.5.5 to ~5.0.2
   - Upgrade Webpack from ^5.69.1 to ^5.76.3
   - Upgrade a bunch of plugins and other dependencies
+- Fix linter warnings in Markdown files and remove default webview/README.md
 
 ## v1.25.0 (2022-06-01)
 
 ### Major change
+
 - Updated from `[email protected]` to `[email protected]` (2e14709)
   - Part of this update forces me to ditch `ssh2-streams` which played a major role for SFTP
   - The `ssh2` package has a built-in but unexposed alternative we can more or less use directly
@@ -57,12 +61,14 @@
   - Mind that some (future) features won't work (maybe just for now, maybe forever) on Windows
 
 ### New features
+
 - Added `FS_NOTIFY_ERRORS` flag to display notifications for FS errors (ddfafd5, #282)
 - Added a `${workingDirectory}` variable that gets replaced during terminal creation (ddfafd5, #323)
   - This applies to both the `Terminal Command` setting and `ssh-shell` task type
   - See the issue (#323) for why this got added and how you can use it
 
 ### Changes
+
 - Small improvements to Dropdown(WithInput) UI components (9c83b07)
 - Delay and wait for loadConfigs() after logging version info (8c8b950)
   - This solves a small issue/annoyance where logs regarding loading logs appear before the version logging
@@ -72,6 +78,7 @@
   - The extension will no longer show notification bubbles for failed `stat` operations due to non-existing files
 
 ### Development changes
+
 - Added `semver` as dependency in preparation of `FS_NOTIFY_ERRORS` flag (57b8ec6)
 - Pin some dependencies and in-range upgrade recursively (c7ac129)
   - More specifically, we now use `typescript@~version` instead of `typescript@^version`
@@ -85,14 +92,17 @@
 ## v1.24.1 (2021-12-07)
 
 ### New features
+
 - The settings UI now has a table-like field to modify `newFileMode` (b904fb9, #214)
 
 ### Changes
+
 - The default `newFileMode` is now `0o664` instead defaulting to the underlying library's `0o666` (af76438, #214)
   - **This changes the permission for newly created files**, defaulting to `rw-rw-r--` instead of `rw-rw-rw-`
   - While `0o664` is the default umask for non-root users and `0o644` for root, **we default to `0o664` regardless**
 
 ### Development changes
+
 - Fix/improve `map-error.js` utility (now also uses `formatId` from `webpack.plugin.js`) (768bfda)
 - Update build process (fa3bc68)
   - Build workflow broke due to using `yarn dlx vsce` and an `vsce` major version update requiring Node 14
@@ -106,6 +116,7 @@
 ## v1.24.0 (2021-11-02)
 
 ### Changes
+
 - Set `$TERM` to `xterm-256color` instead of the default `vt100` (16ffd1e, #299)
 - Terminals that exit within 5 seconds should now remain open until a key is pressed (55d7216)
 - Refactored the `REMOTE_COMMANDS` beta feature (#270) to use the new `ShellConfig` system (b9f226e)
@@ -114,34 +125,41 @@
   - Using `$PATH` should allow support for recursive shells, switching shells, ...
 
 ### Fixes
+
 - Write `REMOTE_COMMANDS` profile script to separate file for each user (69c2370, #292)
   - Multiple users making use of this feature would use the same `/tmp/...` file, resulting in permission issues
 
 ### New features
+
 - Added a `ShellConfig` system to support more shells regarding `environment`, home detection and `REMOTE_COMMANDS` (cc823c6)
 
 ## v1.23.1 (2021-10-06)
 
 ### Hotfix
+
 - Fix the issue with failing home detecting for `csh`/`tcsh` shells (7605237, #295)
 
 ### Development changes
+
 - More improvements in logging, especially regarding async stack tracing (e326a16)
   - Properly "set boundaries",  detect/analyze and log `toPromise`/`catchingPromise` calls
 
 ## v1.23.0 (2021-10-02)
 
 ### Fixes
+
 - Fix remote `code` command (#267) not working without the filesystem already connected (#292) (b821bae)
 - Fix bug with broken connections when connections are initiated by spawning named terminals (6f6e3ad)
 - Fix issue where `.bashrc` echoing would result in home directory detection failing (860f65a, #294)
 
 ### Changes
+
 - Proxy hop field now actually lists all known configs to pick from, instead of "TO DO" (1f7e333, #290)
 - Remote `code` command (#267) now prompts to create an empty file for non-existing path (30c213a)
 - Remote `code` command (#267) now displays a help message when not providing arguments (518e246)
 
 ### Development changes
+
 - Webpack setup has been improved quite a bit, mostly to clean up long ugly paths and make builds deterministic:
   - The custom `ProblemMatcherReporter` plugin is moved to `/webpack.plugin.js` and renamed to `WebpackPlugin`
   - Now both webpack configs (extension and webview) make use of this plugin
@@ -165,35 +183,43 @@
 ## 1.22.0 (2021-09-21)
 
 ### Fixes
+
 - Partially fix issue with debug mode on code-server (05e1b69, #279)
 
 ### Development changes
+
 - I've added a `CHANGELOG.md` file to the repository containing the changelog for earlier versions. It'll contain already committed changes that have yet to be released.
 - The extension now only enters debug mode when the environment variable `VSCODE_SSHFS_DEBUG` is the (case insensitive) string `"true"`. The `ExtensionContext.extensionMode` provided by Code does not influence this anymore. This is part due to #279, implemented in 05e1b69 which supersedes 48ef229.
 
 ## 1.21.2 (2021-08-05)
 
 ### Fixes
+
 - Fix bug in connect command with `Root` starting with `~` (803dc59, #280)
 
 ### Changes
+
 - Remove `(SSH FS)` label from editor titles (fcbd6d7, #278)
 
 ## 1.21.1 (2021-08-01)
 
 ### Fixes
+
 - Improve effect of `CHECK_HOME` flag (ef40b07b2d, #277)
 
 ### Changes
+
 - Better error handling and `CHECK_HOME` flag support for `tryGetHome` (87d2cf845a)
 
 ### Development changes
+
 - Improve `map-error.js` to work for `/dist/extension.js` and error report better (bda36c998c)
 - Improve logging of errors through promises (c7f1261311)
 
 ## 1.21.0 (2021-07-01)
 
 ### Major change (315c255)
+
 - An internal change happened, making URIs now represent an absolute path on the server
 - In the past, `ssh://config/some/path` for a config with `/root` as Root would actually point to `/root/some/path` on the remote server
 - Now, the Root is ignored, so `ssh://config/some/path` will actually point at `/some/path` on the remote server
@@ -202,9 +228,11 @@
 - This change simplifies a lot of complex code accounting for calculating/validating relative paths, and also allows for future improvements, a good example being a beta feature shown in #267
 
 Fixes:
+
 - Fix proxies breaking when no port is defined (which should default to 22) (a41c435, #266)
 
 New features:
+
 - Added `statusBar/remoteIndicator` (remote button left-bottom) (d3a3640, #260)
 See microsoft/vscode#122102 for info and [this](https://code.visualstudio.com/updates/v1_56#_remote-indicator-menu) for an example (with different extensions)
 - Add support for environment variables (3109e97, #241)
@@ -222,30 +250,35 @@ It will tell the extension (and thus VS Code) to open the file/directory. Files
 Due to how complex and unreliable it is to inject aliases, this feature is still in beta and subject to change.
 
 Minor changes:
+
 - Added `virtualWorkspaces` capabilities to `package.json` (8789dd6)
 - Added `untrustedWorkspaces` capabilities (cca8be2, #259, microsoft/vscode#120251)
 - The `Disconnect` command now only shows connections to choose from (36a440d)
 - Added `resourceLabelFormatters` contribution, for better Explorer tooltips (5dbb36b)
-- Added `viewsWelcome ` contribution, to fill in empty configs/connections panes (4edc2ef)
+- Added `viewsWelcome` contribution, to fill in empty configs/connections panes (4edc2ef)
 
 Development changes:
+
 - Added some initial when clause contexts (b311fec)
   - Currently only `sshfs.openConnections`, `sshfs.openTerminals` and `sshfs.openFileSystems`
 - Some small refactors and improvements (5e5286d, 06bce85, f17dae8, 1258a8e, f86e33a)
 
 ## 1.20.2 (2021-06-28)
 
 ### Fixes
+
 - Allow usernames with dashes for instant connection strings (#264, f05108a)
 This only affected the "Create instant connection" option within certain commands in the public version of the extension.
 This also affected people (manually) using connection strings to interact with file systems or use as `"hop"` within JSON configs.
 
 ### New features
+
 - Add config option for agent forwarding (#265, d167ac8)
 The settings UI now has a simple checkbox to toggle agent forwarding.
 Mind that this automatically gets disabled if you authenticate without an agent!
 
 ### Development changes
+
 - Updated to TypeScript 4.3.4
 - Updated `defaultStyles.css` for VS Code CSS variables
 - Settings UI now supports checkbox fields
@@ -254,6 +287,7 @@ Mind that this automatically gets disabled if you authenticate without an agent!
 ## 1.20.1 (2021-04-14)
 
 ### Fixes
+
 - Closing connection shouldn't delete workspace folders if a related filesystem exists (cdf0f99)
   Basically you have connection A (with a terminal or so) and connection B (with a file system) both for the same config name.
   Before, closing connection A would also delete/remove the workspace folder, even though connection B still provides the file system.
@@ -262,6 +296,7 @@ Mind that this automatically gets disabled if you authenticate without an agent!
   Mind that you'll also need to change `Terminal Command` into e.g. `powershell`, as Windows doesn't support the `$SHELL` variable
 
 ### Changes
+
 - The extension now tracks which version was last used (fdb3b66)
   Currently unused, but might be used in the future to notify the user of breaking changes, optionally with auto-fix.
 - Config flags can now be specified per config (9de1d03)
@@ -275,6 +310,7 @@ Mind that this automatically gets disabled if you authenticate without an agent!
 ## 1.20.0 (2021-03-19)
 
 ### New features
+
 - Add task variables for remote files #232 ([example](https://user-images.githubusercontent.com/14597409/111828756-0d326d00-88ec-11eb-9988-0768e1194cca.png))
   - Supported variables (e.g. `${remoteFile}`) can be seen [here](https://github.com/SchoofsKelvin/vscode-sshfs/blob/v1.20.0/src/manager.ts#L216)
   - Some variables support a workspace name as argument, similar to the built-in variables, e.g. `${remoteWorkspaceFolder:FolderName}`
@@ -283,6 +319,7 @@ Mind that this automatically gets disabled if you authenticate without an agent!
   - Setting it to e.g. `echo A; $COMMAND; echo B` results in the task echoing `A`, running the task command, then echoing `B`
 
 ### Development changes
+
 - Switched from official `ssh2-streams` to [Timmmm/ssh2-streams#patch1](https://github.com/Timmmm/ssh2-streams/tree/patch-1)
   - Potentially fixing #244
 - Updated to TypeScript 4.2.3
@@ -294,17 +331,20 @@ Mind that this automatically gets disabled if you authenticate without an agent!
 ## 1.19.4 (2021-03-02)
 
 ### Changes
+
 - Flag system is improved. The `DF-GE` flag (see #239) will now automatically enable/disable for affected Electron versions.
   People that were making use of the `DF-GE` flag to **disable** this fix, should now use `-DF-GE` or `DF-GE=false` instead.
 
 ### Development changes
+
 - GitHub Actions workflow now makes use of the [Event Utilities](https://github.com/marketplace/actions/event-utilities) GitHub action (6d124f8)
   This is mostly the old code, but now better maintained and made publicly available to anyone.
   Doesn't really affect the extension. Just cleans up the workflow file, instead of requiring a relatively big complex chunk of bash script.
 
 ## 1.19.3 (2021-02-15)
 
 ### Changes
+
 - Instant connections with as hostname an existing config will result in the configs being merged
   - e.g. `user2@my-config` will use the same config as `my-config`, but with `user2` as the user
   - The "instant connection bonuses" are still applied, e.g. trying to match the (new) config against a PuTTY session on Windows
@@ -318,17 +358,20 @@ Mind that this automatically gets disabled if you authenticate without an agent!
 - Fixed a bug regarding the `SFTP Sudo` config field misbehaving in the config editor
 
 ### Other news
+
 I'm in the process of claiming the "Kelvin" namespace on the Open VSX Registry.
 In the future, new versions will also be pushed to it, instead of relying on their semi-automated system to do it _sometime_.
 
 ## 1.19.2 (2021-02-11)
 
 ### Hotfix
+
 - Add an auto-enabled patch for #239
   - Disables all `diffie-hellman-group-exchange` KEX algorithms _(unless the user overrides this option)_
   - Adding the flag `DF-GE` to your `sshfs.flags`, e.g. `"sshfs.flags": ["DF-GE"]` **disables** this fix
 
 ### New features
+
 - **Instant connections**
   - The "Add as Workspace Folder" and "Open remote SSH terminal" now suggest "Create instant connection"
   - Allows easily setting up unconfigured connections, e.g. `[email protected]:22/home/user`
@@ -344,6 +387,7 @@ Allows specifying flags to change certain options/features that aren't supported
 - Adding `"debug": true` to your SSH FS config will enable `ssh2`/`ssh2-streams` debug logging for that config
 
 ### Development changes
+
 - The GitHub repository now has a workflow (GitHub Actions) to build the extension and draft releases
 - Improve how the extension "simplifies" error messages for missing files for (built-in) extension checks
   - Now supports workspace folders with `ssh://name/path` as URI instead of just `ssh://name/`
@@ -358,24 +402,29 @@ Allows specifying flags to change certain options/features that aren't supported
 ## 1.19.1 (2020-12-17)
 
 ### New features
+
 - Add TerminalLinkProvider for absolute paths
 
 ### Changes
+
 - Upgrade `@types/vscode` and minimum VSCode version from 1.46.0 to 1.49.0
 - Small internal improvements
 - Fix some bugs
 
 ## 1.19.0 (2020-12-17)
 
 ### New features
+
 - `SSH FS` view with nice UI for listing configs, managing connections/terminals, ...
 - Support prompting the `Host` field
 - Add `Terminal command` field to change the terminal launch command _(defaults to `$SHELL`)_
 
 ### Changes
+
 - Upgrade codebase to [email protected]
 - Refactor Manager, add ConnectionManager
 - Small bug fixes, improved logging, ...
 
 ## Earlier
+
 Check the [releases](https://github.com/SchoofsKelvin/vscode-sshfs/releases) page to compare commits for older versions.