Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change nerf methods mapping and add thermal predicted image only output #13

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Change nerf methods mapping and add thermal predicted image only output #13

merged 1 commit into from
Oct 2, 2024

Conversation

jiaruiyu99
Copy link
Collaborator

  • change methods mapping in train_eval_script.py
  • add thermal and thermal_combined images output

MalcolmMielle
MalcolmMielle requested changes Sep 26, 2024
View reviewed changes
scripts/train_eval_script.py Outdated Show resolved Hide resolved
@jiaruiyu99 jiaruiyu99 force-pushed the change_method_mapping branch from 2b4353d to 9c5f720 Compare September 26, 2024 15:30
MalcolmMielle
MalcolmMielle requested changes Sep 26, 2024
View reviewed changes
thermo_nerf/render/renderer.py Outdated Show resolved Hide resolved
thermo_nerf/scripts/train_eval_script.py Outdated Show resolved Hide resolved
thermo_nerf/thermal_nerf/thermal_nerf_model.py Outdated Show resolved Hide resolved
@jiaruiyu99 jiaruiyu99 force-pushed the change_method_mapping branch from 9c5f720 to d8e08fe Compare September 27, 2024 08:08
MalcolmMielle
MalcolmMielle requested changes Sep 27, 2024
View reviewed changes
thermo_nerf/scripts/renderimagemodality_type.py Outdated Show resolved Hide resolved
thermo_nerf/scripts/renderimagemodality_type.py Outdated Show resolved Hide resolved
thermo_nerf/scripts/model_type.py Outdated Show resolved Hide resolved
thermo_nerf/thermal_nerf/thermal_nerf_model.py Outdated Show resolved Hide resolved
@jiaruiyu99 jiaruiyu99 force-pushed the change_method_mapping branch from d8e08fe to aeece84 Compare September 27, 2024 12:04
@jiaruiyu99 jiaruiyu99 force-pushed the change_method_mapping branch from aeece84 to 0998145 Compare September 27, 2024 15:22
@jiaruiyu99 jiaruiyu99 force-pushed the change_method_mapping branch from 0998145 to a9415e7 Compare September 27, 2024 15:30
@jiaruiyu99 jiaruiyu99 force-pushed the change_method_mapping branch 2 times, most recently from 1160f5e to dcc5e21 Compare September 30, 2024 09:51
MalcolmMielle
MalcolmMielle requested changes Sep 30, 2024
View reviewed changes
thermo_nerf/rgb_concat/concat_nerfacto_model.py Outdated Show resolved Hide resolved
thermo_nerf/field_heads.py Outdated Show resolved Hide resolved
@jiaruiyu99 jiaruiyu99 force-pushed the change_method_mapping branch from dcc5e21 to ef4c072 Compare October 1, 2024 08:47
@jiaruiyu99 jiaruiyu99 force-pushed the change_method_mapping branch from ef4c072 to 42b08b7 Compare October 2, 2024 09:20
@jiaruiyu99 jiaruiyu99 force-pushed the change_method_mapping branch from 42b08b7 to ac52b20 Compare October 2, 2024 13:24
@jiaruiyu99 jiaruiyu99 added the trigger_pipeline Trigger the pipeline for validation label Oct 2, 2024
@jiaruiyu99 jiaruiyu99 force-pushed the change_method_mapping branch from ac52b20 to f7ac977 Compare October 2, 2024 13:39
@jiaruiyu99 jiaruiyu99 added trigger_pipeline Trigger the pipeline for validation and removed trigger_pipeline Trigger the pipeline for validation labels Oct 2, 2024
@jiaruiyu99 jiaruiyu99 force-pushed the change_method_mapping branch from f7ac977 to 09d0bd2 Compare October 2, 2024 13:42
@jiaruiyu99 jiaruiyu99 added trigger_pipeline Trigger the pipeline for validation and removed trigger_pipeline Trigger the pipeline for validation labels Oct 2, 2024
@jiaruiyu99 jiaruiyu99 force-pushed the change_method_mapping branch from 09d0bd2 to 90a132b Compare October 2, 2024 13:44
@jiaruiyu99 jiaruiyu99 added trigger_pipeline Trigger the pipeline for validation and removed trigger_pipeline Trigger the pipeline for validation labels Oct 2, 2024
@jiaruiyu99 jiaruiyu99 force-pushed the change_method_mapping branch from 90a132b to e81579d Compare October 2, 2024 13:47
@jiaruiyu99 jiaruiyu99 added trigger_pipeline Trigger the pipeline for validation and removed trigger_pipeline Trigger the pipeline for validation labels Oct 2, 2024
@jiaruiyu99
Change nerf methods mapping and add thermal predicted image only output
608da76 
- change methods mapping in `train_eval_script.py`
- add `thermal` and `thermal_combined` images output
@jiaruiyu99 jiaruiyu99 force-pushed the change_method_mapping branch from e81579d to 608da76 Compare October 2, 2024 13:49
@jiaruiyu99 jiaruiyu99 added trigger_pipeline Trigger the pipeline for validation and removed trigger_pipeline Trigger the pipeline for validation labels Oct 2, 2024
@jiaruiyu99 jiaruiyu99 merged commit 50768e2 into Schindler-EPFL-Lab:main Oct 2, 2024
1 check passed
@jiaruiyu99 jiaruiyu99 deleted the change_method_mapping branch October 2, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MalcolmMielle MalcolmMielle MalcolmMielle approved these changes

@mariamhegazy mariamhegazy Awaiting requested review from mariamhegazy mariamhegazy is a code owner

Assignees
No one assigned
Labels
trigger_pipeline Trigger the pipeline for validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiaruiyu99 @MalcolmMielle