Use lowercase for TypeScript moduleResolution compiler option #4210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnaudBarre
requested review from
madskristensen and
hyperupcall
as code owners
|
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
jakebailey
approved these changes
Nov 12, 2024
|
Thanks! I think |
|
Awesome, thanks!- Feel free to edit other tsconfig/jsconfig enums similarly¶ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The casing is a bit inconsistent, it's lowercase in the cli and the most of the documentation, but PascalCase in the default of the doc and the JSON schema. I think using the lowercase like in the cli make more sense.
I can make this change for more enums if needed.
Pinging @RyanCavanaugh @jakebailey that seems to be owner of the schema