Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support case-insensitive uniqueness validations under MySQL #39

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+6 −2
Open

Support case-insensitive uniqueness validations under MySQL #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
316f6f3
Fix case-insensitivity uniqueness validation for MySQL.
dmeranda Apr 19, 2016
89f54f0
Only call the column's case_sensitive? if it is determined by the col…
dmeranda Apr 19, 2016
ac3ed28
Readme should mention schema_plus_pg_indexes only needed for PostgreSQL.
dmeranda Apr 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ Constraints:
| `null: false` | `validates ... presence: true` |
| `limit: 100` | `validates ... length: { maximum: 100 }` |
| `unique: true` | `validates ... uniqueness: true` |
| `unique: true, case_sensitive: false` <br>(If [schema_plus_pg_indexes](https://github.com/SchemaPlus/schema_plus_pg_indexes) is also in use) | `validates ... uniqueness: { case_sensitive: false }` |
| `unique: true, case_sensitive: false` <br>(Requires [schema_plus_pg_indexes](https://github.com/SchemaPlus/schema_plus_pg_indexes) for PostgreSQL) | `validates ... uniqueness: { case_sensitive: false }` |

Data types:

Expand Down
6 changes: 5 additions & 1 deletion lib/schema_validations/active_record/validations.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ def add_uniqueness_validation(column) #:nodoc:
options = {}
options[:scope] = scope if scope.any?
options[:allow_nil] = true
options[:case_sensitive] = false if has_case_insensitive_index?(column, scope)
options[:case_sensitive] = false if column_is_case_insensitive?(column) or has_case_insensitive_index?(column, scope)
options[:if] = (proc do |record|
if scope.all? { |scope_sym| record.public_send(:"#{scope_sym}?") }
record.public_send(:"#{column.name}_changed?")
Expand All @@ -181,6 +181,10 @@ def add_uniqueness_validation(column) #:nodoc:
validate_logged :validates_uniqueness_of, name, options
end

def column_is_case_insensitive?(column)
column.respond_to?(:collation) && column.respond_to?(:case_sensitive?) && ! column.case_sensitive?
end

def has_case_insensitive_index?(column, scope)
indexed_columns = (scope + [column.name]).map(&:to_sym).sort
index = column.indexes.select { |i| i.unique && i.columns.map(&:to_sym).sort == indexed_columns }.first
Expand Down