Add support for python 3.12

[branchvincent]

Adds explicit support for Python 3.12. These are the minimal changes I needed for pytest to pass on 3.12 and macOS:

• Replaces deprecated datetime.datetime.utcnow
• Replaces called_once_with with assert_called_once_with, which now raises AttributeError: 'called_once_with' is not a valid assertion
• Bumps pytest due to DeprecationWarning: ast.Str is deprecated and will be removed in Python 3.14; use ast.Constant instead [Python 3.12] Assertion rewriting triggers DeprecationWarning pytest-dev/pytest#10977
• Refreshes the lockfile

depends on #1393

[iainelder]

Hi, @branchvincent . The contribution is timely because we are in the middle of dropping support for Python 3.7 (#1381). I would wait for that work to complete before merging this.

Dropping Python 3.7 requires changes in 4 different repos. I think the same will be true to add Python 3.12.

Your changes make a good start. I think to complete the work we also need to address these repos:

• https://github.com/Sceptre/sceptre-circleci (May be covered by Update python versions sceptre-circleci#19)
• https://github.com/Sceptre/sceptre-resolver-cmd
• https://github.com/Sceptre/sceptre-file-resolver

[iainelder]

@branchvincent I read Homebrew/homebrew-core#155493. I'm unfamiliar with Homebrew. Why does it need Sceptre to support 3.12?

[zaro0508]

thanks @branchvincent. This depends on PR #1393

[branchvincent]

@iainelder glad it's good timing :)

Your changes make a good start. I think to complete the work we also need to address these repos:

I tested both https://github.com/Sceptre/sceptre-resolver-cmd and https://github.com/Sceptre/sceptre-file-resolver on 3.12 and had no issues (beyond outdated requirements.txt files, but those don't impact the published package). Btw, I noticed this repo switch to using poetry, would you be interested in PRs switching those repos as well?

Why does it need Sceptre to support 3.12?

We're a rolling-release package manager, so we do our best to always stay on the latest stable version of packages (including python, go, rust, etc)

[dpulls]

🎉 All dependencies have been resolved !

[iainelder]

I noticed this repo switch to using poetry, would you be interested in PRs switching those repos as well?

Makes sense to me. @zaro0508 , is there a reason not to use Poetry for those resolvers?

[zaro0508]

is there a reason not to use Poetry for those resolvers?

No @iainelder, we would love to see that happen. Someone just needs to do it 😄

[dpulls]

🎉 All dependencies have been resolved !

[branchvincent]

we would love to see that happen

Created Sceptre/sceptre-file-resolver#12 and Sceptre/sceptre-resolver-cmd#13. Left as draft because it needs this PR for python 3.12 support

Also, note I reworked the CircleCI config to not depend on the custom docker image (wasn't sure if that had a specific purpose) and instead use the official cimg/python image and their official python orb (which provides poetry caching out of the box). The tests now run in parallel on each supported python version

[dpulls]

🎉 All dependencies have been resolved !

[zaro0508]

@branchvincent would you mind resolving the conflicts on this PR?

[branchvincent]

@zaro0508 done

[zaro0508]

thanks @branchvincent

[iainelder]

Also, note I reworked the CircleCI config to not depend on the custom docker image (wasn't sure if that had a specific purpose)

@zaro0508 and I have been flip-flopping on whether we need the custom image or not. (Yes: #1393; No: #1394). I noticed that the img/python:3.12 contains versions python3.10 and python3.12 but not the rest. So the reason for the custom image would be to install the missing versions (see Sceptre/sceptre-circleci#19 to update the Dockerfile for Python 3.12)

and instead use the official cimg/python image and their official python orb (which provides poetry caching out of the box). The tests now run in parallel on each supported python version

@branchvincent , I don't see that in the changes files of this PR. Can you show me where you made these changes?

To drop the custom image, this orb thing sounds like the part we need, and a more idiomatic use of CircleCI.

Is it fair to say that a CircleCI orb is like a GitHub Actions action? (I use GitHub Actions a lot, and this project is my first exposure to CircleCI.)

[iainelder]

I reworked the CircleCI config to not depend on the custom docker image

I don't see that in the changes files of this PR

I see you mean you changed the CircleCI config in the resolver repos:

• migrate to poetry sceptre-resolver-cmd#13
• migrate to poetry sceptre-file-resolver#12

That's great! If it works then it would be good to copy the changes to this repo's CircleCI config too.

[branchvincent]

Is it fair to say that a CircleCI orb is like a GitHub Actions action?

Yes exactly that's my understanding!

I just created #1395 to copy those CI changes here