Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've ran into an issue with one of our Python app that causes Scalingo to fail the
pipenv install
step when rebuilding the app. I've tried and document it here:https://gist.github.com/freesteph/de580c30f9545394cdc3666be52443a6
Using the commit in this PR fixes our issue, so we were wondering if you might be interested in upgrading pipenv too.
Original commit message
The current version is two years old and is causing some of our packages installation to fail with messages such as:
Installing dependencies from Pipfile.lock (63c834)... error in
setup command: 'extras_require' must be
a dictionary whose values are strings or lists of strings
containing valid project/version requirement specifiers.
With the relevant section in said package:
There is no clear violation of the expected format, however the package is installed from a Git source. That's all I've gathered at this point and I can't find a clear fix but this issue:
pypa/pipenv#4309
Upgrading the pipenv version does fix the problem, so upgrade to the latest possible version and roll with it.