Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipenv: upgrade Pipenv #69

Closed
wants to merge 1 commit into from
Closed

Conversation

freesteph
Copy link

Description

We've ran into an issue with one of our Python app that causes Scalingo to fail the pipenv install step when rebuilding the app. I've tried and document it here:

https://gist.github.com/freesteph/de580c30f9545394cdc3666be52443a6

Using the commit in this PR fixes our issue, so we were wondering if you might be interested in upgrading pipenv too.

Original commit message

The current version is two years old and is causing some of our packages installation to fail with messages such as:

Installing dependencies from Pipfile.lock (63c834)... error in
setup command: 'extras_require' must be
a dictionary whose values are strings or lists of strings
containing valid project/version requirement specifiers.

With the relevant section in said package:

extras_require={
    "Flask": ["Flask"],
    "dev": [
        "pytest",
        "pytest-flakes",
        "pytest-helpers-namespace",
    ],
},

There is no clear violation of the expected format, however the package is installed from a Git source. That's all I've gathered at this point and I can't find a clear fix but this issue:

pypa/pipenv#4309

Upgrading the pipenv version does fix the problem, so upgrade to the latest possible version and roll with it.

The current version is two years old and is causing some of our
packages installation to fail with messages such as:

  Installing dependencies from Pipfile.lock (63c834)...  error in
        <somepackage> setup command: 'extras_require' must be
        a dictionary whose values are strings or lists of strings
        containing valid project/version requirement specifiers.

With the relevant section in said package:

    extras_require={
        "Flask": ["Flask"],
        "dev": [
            "pytest",
            "pytest-flakes",
            "pytest-helpers-namespace",
        ],
    },

There is no clear violation of the expected format, however the
package is installed from a Git source. That's all I've gathered at
this point and I can't find a clear fix but this issue:

pypa/pipenv#4309

Upgrading the pipenv version does fix the problem, so upgrade to the
latest possible version and roll with it.
@brandon-welsch
Copy link
Member

Thanks for the report. This change will be handled in the following PR: #77. So i will close your issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants