Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Inventory for heroku/nodejs engine (heroku#1144) #93

Closed
wants to merge 18 commits into from

Conversation

Barokai
Copy link

@Barokai Barokai commented Oct 25, 2023

Adds support for node 21, 18.18.1, 18.18.2, 20.8.0, 20.8.1

v226 (2023-10-19)
Added Node.js version 21.0.0.
Add metrics and tests for Node.js 21. (heroku#1161)
v225 (2023-10-17)
Added Node.js version 20.8.1.
Added Node.js version 18.18.2.
v224 (2023-10-11)
Added Node.js version 18.18.1.
Report errors when checking npm and yarn output (heroku#1147)
v223 (2023-10-04)
Added Node.js version 20.8.0.
Added Yarn version 3.6.4.
Added Yarn version 4.0.0-rc.52.
Added Yarn version 4.0.0-rc.53.

heroku-linguist bot and others added 18 commits October 4, 2023 13:18
- Added Node.js version 20.8.0.

Co-authored-by: joshwlewis <[email protected]>
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update Inventory for heroku/nodejs yarn

- Added Yarn version 3.6.4.

* Update CHANGELOG.md

---------

Co-authored-by: joshwlewis <[email protected]>
Co-authored-by: Colin Casey <[email protected]>
* fix: do not ignore errors when checking npm/yarn output

Dropping stderr/stdout on the floor results in mysterious buildpack failures in certain cases. For instance, if there is a `.yarnrc.yml` that requires an environment variable, `yarn --version` will output an error, but then the existing code would just silence that, causing users to think that the yarn install failed with no real recourse.

* docs: add changelog entry
- Added Node.js version 18.18.1.

Co-authored-by: joshwlewis <[email protected]>
Currently the inventory update PRs don't use the bot user for the
commit author, but instead the Josh's user, eg:
heroku@9bd0ec1

Now the author is set to our bot user, the same way we do in other repos, eg:
https://github.com/heroku/languages-github-actions/blob/5dde4b7d832209dc8d6862d083a41a18d72c7c32/.github/workflows/_buildpacks-prepare-release.yml#L104-L106

In addition, the `automation` label is no longer set, for the same
reasons as:
heroku/languages-github-actions#109

GUS-W-14283836.
…#1155)

Ruby minor/patch dependencies will now be grouped, using the new
Dependabot grouping feature:
https://github.blog/changelog/2023-08-17-grouped-version-updates-by-semantic-version-level-for-dependabot/

This hasn't been enabled for the GitHub Actions dependencies, since
they all use major pinning (since we only use the official actions
like `actions/checkout`).

In addition, the check changelog skipping strategy has been updated to
use the `skip changelog` label for (a) explicitness, (b) to allow removing
the label in situations where we realise a changelog entry is required,
(c) for consistency with other repos.

Lastly, the redundant `gomod` entry in the Dependabot config has been
removed (a leftover from heroku#1061).

GUS-W-14303554.
- Added Node.js version 18.18.2.
- Added Node.js version 20.8.1.

Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
…#1158)

Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.17.9 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the ruby-dependencies group with 1 update: [rspec-expectations](https://github.com/rspec/rspec-expectations).

- [Release notes](https://github.com/rspec/rspec-expectations/releases)
- [Changelog](https://github.com/rspec/rspec-expectations/blob/main/Changelog.md)
- [Commits](rspec/rspec-expectations@v3.12.2...v3.12.3)

---
updated-dependencies:
- dependency-name: rspec-expectations
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: ruby-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- Added Node.js version 21.0.0.

Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
* Updates metrics plugins and tests for Node 21
@EtienneM
Copy link
Member

Duplicate of #92

@EtienneM EtienneM marked this as a duplicate of #92 Oct 25, 2023
@EtienneM EtienneM closed this Oct 25, 2023
@@ -0,0 +1 @@
107fa5474f01fce59c2b7e9d17411f161feddd1a0537ac85798ae8804d66ebe17285d66062adfe75472b64006951b81dcc322e4918e2ee5c6f3fae96c24dd1e6 heroku-nodejs-plugin-node-21-v13.tar.gz
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about these files in the plugin directory, they need to be removed probably

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants