Added BIG size, 72dp size for fab buttons, Fix MOVE feedback, update gitignore #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shell-software Probably this has conflicts due not well formed .gitignore that add gradle files to the repository |
|
Hi Aracem, The pull has been accepted with modifications:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 Added BIG size for fab buttons. Big size shows a 72dp fab button. Could be useful for some projects.
I have a little problems with your code style. I use Android AOSP code style. If you have problem whith this please comment and cancel the pull request. I will make another one with your code style.
2 Resolve the problem with the OnTouchEvent - MOVE that causes the ActionButton stay Pressed when the user clicks and move the finger out of the ActionButton.
3 Improve .gitignore to not add unneccesary files
Thank you so much