Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use generator to export all api model enums #117

Merged
merged 2 commits into from
May 20, 2021

Conversation

nguyentoanit
Copy link
Contributor

No description provided.

@nguyentoanit nguyentoanit requested a review from moltar May 20, 2021 10:25
@nguyentoanit nguyentoanit self-assigned this May 20, 2021
@moltar
Copy link
Contributor

moltar commented May 20, 2021

Task linked: GHORG-66 Export all enums from root

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2021

Codecov Report

Merging #117 (f9c93c8) into master (8470a5d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #117   +/-   ##
=======================================
  Coverage   56.96%   56.96%           
=======================================
  Files          47       47           
  Lines         409      409           
  Branches       20       20           
=======================================
  Hits          233      233           
  Misses        176      176           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8470a5d...f9c93c8. Read the comment docs.

Copy link
Contributor

@moltar moltar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But please also run the generator to see what diff we'll have after this change.

exportings.push(`${key} as ${upperFirst(camelCase(model.dirname))}${key}`)
}
}
const exportings = [...sourceFile.getEnums(), ...sourceFile.getInterfaces()]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename to exports.

@nguyentoanit nguyentoanit merged commit 555f372 into master May 20, 2021
@nguyentoanit nguyentoanit deleted the chore/GHORG-66-export-all-enums-from-root branch May 20, 2021 12:07
@github-actions
Copy link
Contributor

🎉 This PR is included in version 3.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants