Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect country code of London region #122

Closed
nguyentoanit opened this issue Mar 6, 2020 · 4 comments
Closed

Incorrect country code of London region #122

nguyentoanit opened this issue Mar 6, 2020 · 4 comments
Labels
released

Comments

@nguyentoanit
Copy link
Contributor

AmazonMarketplaceAdvertisingCountryCode enum contains GB country code. But i think it's incorrect. It should be UK.

Ref: Regional profile time zone codes
@nguyentoanit nguyentoanit mentioned this issue Mar 6, 2020
Closed
@moltar
Copy link
Collaborator

moltar commented Mar 6, 2020

Hm, that is an interesting observation!

In MWS docs, they use GB.

That is the official ISO country code.

I'm going to open an issue with Amazon Advertising team in Jira.

Is this UK value used anywhere as input or output from the API? Or is it just part of the docs?

Thanks

@moltar
Copy link
Collaborator

moltar commented Mar 6, 2020

Opened a Jira issue ADAPI-4698

@nguyentoanit
Copy link
Contributor Author

It is output from Amazon Advertising API when i get Profile list.
currencyCode, timezone, marketplaceStringId are still fine. But countryCode is UK not GB

{
  "profileId": 123456789,
  "countryCode": "UK",
  "currencyCode": "GBP",
  "dailyBudget": 0.0,
  "timezone": "Europe/London",
  "accountInfo": {
    "marketplaceStringId": "A1F83G8C2ARO7P",
    "id": "XXXXXX",
    "type": "seller"
  }
}

moltar added a commit that referenced this issue Mar 9, 2020
@moltar
fix: adds countryCode to AmazonMarketplaceAdvertising
9629d5e 
Adds countryCode prop to AmazonMarketplaceAdvertising, that is separate
from Amazon Marketplace countryCode, as it uses different values.

BREAKING CHANGE: Adds countryCode to AmazonMarketplaceAdvertising that is different from AmazonMarketplaceCountryCode enum.
Closes #122
moltar added a commit that referenced this issue Mar 9, 2020
@moltar
fix: adds countryCode to AmazonMarketplaceAdvertising
82b043f 
Adds countryCode prop to AmazonMarketplaceAdvertising, that is separate
from Amazon Marketplace countryCode, as it uses different values.

BREAKING CHANGE: Adds countryCode to AmazonMarketplaceAdvertising that is different from AmazonMarketplaceCountryCode enum.
Closes #122
moltar added a commit that referenced this issue Mar 9, 2020
@moltar
fix: adds countryCode to AmazonMarketplaceAdvertising
93a441e 
Adds countryCode prop to AmazonMarketplaceAdvertising, that is separate
from Amazon Marketplace countryCode, as it uses different values.

BREAKING CHANGE: Adds countryCode to AmazonMarketplaceAdvertising that is different from AmazonMarketplaceCountryCode enum.
Closes #122
@moltar moltar closed this as completed in d953e3a Mar 9, 2020
github-actions bot pushed a commit that referenced this issue Mar 9, 2020
@semantic-release-bot
chore(release): 3.0.0 [skip ci]
ab9a725 
# [3.0.0](v2.0.0...v3.0.0) (2020-03-09)

### Bug Fixes

* adds countryCode to AmazonMarketplaceAdvertising ([d953e3a](d953e3a))

### Code Refactoring

* renames AmazonMarketplaceAdvertisingCountryCode ([85198cd](85198cd))

### BREAKING CHANGES

* Adds countryCode to AmazonMarketplaceAdvertising that is different from AmazonMarketplaceCountryCode enum.
Closes #122
* Renames AmazonMarketplaceAdvertisingCountryCode enum to AmazonMarketplaceCountryCode
@github-actions
Copy link

github-actions bot commented Mar 9, 2020

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moltar @nguyentoanit