Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enables passing of extra headers to HTTP client #978

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

tmhung88
Copy link
Contributor

@tmhung88 tmhung88 commented Sep 2, 2022

Context: For the latest Advertising APIs, Amazon has moved the version from the uri to contentType. For instance: SpKeywordRecommendation has these possible content types

Content-Type: application/vnd.spkeywordsrecommendation.v3+json | application/vnd.spkeywordsrecommendation.v4+json | application/vnd.spkeywordsrecommendation.v5+json

Problem: A developer who is interested in new APIs cannot extend the SDK, and override the default headers.

Solution: Enable post/put/get/delete methods to accept custom headers. With that, developers can add new operations.

@moltar moltar changed the title fix: Enable to pass custom headers feat: enables passing of extra headers to HTTP client Sep 2, 2022
@moltar moltar merged commit 92a48f6 into ScaleLeap:master Sep 2, 2022
github-actions bot pushed a commit that referenced this pull request Sep 2, 2022
# [3.7.0](v3.6.1...v3.7.0) (2022-09-02)

### Features

* enables passing of extra headers to HTTP client ([#978](#978)) ([92a48f6](92a48f6))
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

🎉 This PR is included in version 3.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants