Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/34 http client finish #35

Merged
merged 13 commits into from
Oct 22, 2019
Merged

Feature/34 http client finish #35

merged 13 commits into from
Oct 22, 2019

Conversation

nguyentoanit
Copy link
Contributor

No description provided.

moltar
moltar requested changes Oct 20, 2019
View reviewed changes
Copy link
Contributor

@moltar moltar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactoring!

I really liked how you decided to use mocked responses, instead of recordings. This feels more like a real unit tests. I didn't even think of that!

I do have a few minor comments that needs to be addressed before we can merge.

Thanks!

test/http-client.test.ts Outdated Show resolved Hide resolved
test/http-client.test.ts Outdated Show resolved Hide resolved
test/http-client.test.ts Show resolved Hide resolved
test/http-client.test.ts Outdated Show resolved Hide resolved
...32634686/download_822653945/should-throw-if-location-header-not-set_2915274416/recording.har Show resolved Hide resolved
@moltar moltar merged commit ee8121d into master Oct 22, 2019
@moltar moltar deleted the feature/34-http-client-finish branch October 22, 2019 16:35
github-actions bot pushed a commit that referenced this pull request Nov 6, 2019
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
de0f3ce 
# 1.0.0 (2019-11-06)

### Bug Fixes

* failing tests ([00f828d](00f828d))
* stops matching on headers ([affb06b](affb06b))

### Features

* adds ability to output to STDOUT ([9168278](9168278))
* adds HTTP client ([8a45622](8a45622))
* adds index ([f56242b](f56242b))
* adds OAuth2 client ([#24](#24)) ([f13694c](f13694c))
* finishes HTTP client ([#35](#35)) ([ee8121d](ee8121d))
@github-actions
Copy link

github-actions bot commented Nov 6, 2019

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moltar moltar moltar approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nguyentoanit @moltar