Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: module not found in @scaleleap/amazon-marketplaces #1025

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

nguyentoanit
Copy link
Contributor

There was a bug in the @scaleleap/amazon-marketplaces package.
Need to update to the latest version to fix this

Closes #1023

@nguyentoanit nguyentoanit self-assigned this Aug 13, 2024
package.json Outdated Show resolved Hide resolved
@jiangdi0924
Copy link

Could you please let me know when this can be merged into the main branch? Thank you.

@moltar
Copy link
Contributor

moltar commented Sep 4, 2024

@nguyentoanit Please wrap this up asap.

@moltar moltar closed this Sep 4, 2024
@moltar moltar reopened this Sep 4, 2024
@nguyentoanit nguyentoanit requested a review from moltar September 11, 2024 04:54
@nguyentoanit nguyentoanit merged commit 251bdf9 into master Sep 11, 2024
9 of 10 checks passed
@nguyentoanit nguyentoanit deleted the fix/module-not-found branch September 11, 2024 04:54
@nguyentoanit
Copy link
Contributor Author

@moltar @jiangdi0924 : We got an issue when release 🐞: https://github.com/ScaleLeap/amazon-advertising-api-sdk/actions/runs/10805243502/job/29972026362

I'm trying to fix it soon.

github-actions bot pushed a commit that referenced this pull request Sep 11, 2024
## [3.8.4](v3.8.3...v3.8.4) (2024-09-11)

### Bug Fixes

* **deps:** update dependency @scaleleap/amazon-marketplaces to v17.3.1 ([#1001](#1001)) ([7fcbed5](7fcbed5))
* **deps:** update dependency agentkeepalive to v4.5.0 ([#1002](#1002)) ([37b5662](37b5662))
* **deps:** update dependency axios to v0.28.1 ([#1003](#1003)) ([ecfff0f](ecfff0f))
* **deps:** update dependency fp-ts to v2.16.6 ([#1004](#1004)) ([3a89683](3a89683))
* **deps:** update dependency fp-ts to v2.16.8 ([#1014](#1014)) ([0028c2c](0028c2c))
* **deps:** update dependency fp-ts to v2.16.9 ([#1021](#1021)) ([499e865](499e865))
* **deps:** update dependency http-status-codes to v2.3.0 ([#1005](#1005)) ([134a848](134a848))
* **deps:** update dependency io-ts to v2.2.21 ([#994](#994)) ([128f0ee](128f0ee))
* **deps:** update dependency io-ts-types to v0.5.19 ([#995](#995)) ([0f589a2](0f589a2))
* **deps:** update dependency lazy-get-decorator to v2.2.1 ([#996](#996)) ([e208f84](e208f84))
* module not found in @scaleleap/amazon-marketplaces ([#1025](#1025)) ([251bdf9](251bdf9)), closes [#1023](#1023)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code: 'MODULE_NOT_FOUND' requestPath: '@scaleleap/amazon-marketplaces'
3 participants